[Reland #1] macOS: Fix a bug in logic to get all memory regions.

[Reland #1] macOS: Fix a bug in logic to get all memory regions.

This CL removes the test NoDuplicateRegions, since grabbing a snapshot of all
regions is not an atomic operation - the very act of iterating through all
regions and recording stats can change the set of all regions.

> macOS: Fix a bug in logic to get all memory regions.
>
> The logic was accidentally double-counting the size of a memory region, causing
> some memory regions to get skipped.
>
> BUG=706547
>
> Review-Url: https://codereview.chromium.org/2786733004
> Cr-Commit-Position: refs/heads/master@{#460585}
> Committed: https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc9bba1867d071

BUG=706547
TBR=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2787143002
Cr-Commit-Position: refs/heads/master@{#460944}
Committed: https://chromium.googlesource.com/chromium/src/+/26bd6d86d59d2c7227e4359d91852426c80134e2

[erikchen, 2017-03-30 21:06:30]

Description was changed from

==========
[Reland #1] macOS: Fix a bug in logic to get all memory regions.

This CL removes the test NoDuplicateRegions, since grabbing a snapshot of all
regions is not an atomic operation - the very act of iterating through all
regions and recording stats can change the set of all regions.

> macOS: Fix a bug in logic to get all memory regions.
>
> The logic was accidentally double-counting the size of a memory region,
causing
> some memory regions to get skipped.
>
> BUG=706547
>
> Review-Url: https://codereview.chromium.org/2786733004
> Cr-Commit-Position: refs/heads/master@{#460585}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...
==========

to

==========
[Reland #1] macOS: Fix a bug in logic to get all memory regions.

This CL removes the test NoDuplicateRegions, since grabbing a snapshot of all
regions is not an atomic operation - the very act of iterating through all
regions and recording stats can change the set of all regions.

> macOS: Fix a bug in logic to get all memory regions.
>
> The logic was accidentally double-counting the size of a memory region,
causing
> some memory regions to get skipped.
>
> BUG=706547
>
> Review-Url: https://codereview.chromium.org/2786733004
> Cr-Commit-Position: refs/heads/master@{#460585}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...

BUG=706547
TBR=primiano@chromium.org
==========

[erikchen, 2017-03-30 21:06:45]

erikchen@chromium.org changed reviewers:
+ primiano@chromium.org

[erikchen, 2017-03-30 21:06:46]

TBRing primiano.

[erikchen, 2017-03-30 21:06:52]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:08:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-03-30 21:17:21]

lgtm

>  the very act of iterating through all
regions and recording stats can change the set of all regions.
yeah same problem on Linux/Android.

[commit-bot: I haz the power, 2017-03-31 00:10:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490908012445600, "parent_rev":
"633b3659cb47272c5d71731cb66b3583df3bc947", "commit_rev":
"26bd6d86d59d2c7227e4359d91852426c80134e2"}

[commit-bot: I haz the power, 2017-03-31 00:12:27]

Description was changed from

==========
[Reland #1] macOS: Fix a bug in logic to get all memory regions.

This CL removes the test NoDuplicateRegions, since grabbing a snapshot of all
regions is not an atomic operation - the very act of iterating through all
regions and recording stats can change the set of all regions.

> macOS: Fix a bug in logic to get all memory regions.
>
> The logic was accidentally double-counting the size of a memory region,
causing
> some memory regions to get skipped.
>
> BUG=706547
>
> Review-Url: https://codereview.chromium.org/2786733004
> Cr-Commit-Position: refs/heads/master@{#460585}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...

BUG=706547
TBR=primiano@chromium.org
==========

to

==========
[Reland #1] macOS: Fix a bug in logic to get all memory regions.

This CL removes the test NoDuplicateRegions, since grabbing a snapshot of all
regions is not an atomic operation - the very act of iterating through all
regions and recording stats can change the set of all regions.

> macOS: Fix a bug in logic to get all memory regions.
>
> The logic was accidentally double-counting the size of a memory region,
causing
> some memory regions to get skipped.
>
> BUG=706547
>
> Review-Url: https://codereview.chromium.org/2786733004
> Cr-Commit-Position: refs/heads/master@{#460585}
> Committed:
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...

BUG=706547
TBR=primiano@chromium.org

Review-Url: https://codereview.chromium.org/2787143002
Cr-Commit-Position: refs/heads/master@{#460944}
Committed:
https://chromium.googlesource.com/chromium/src/+/26bd6d86d59d2c7227e4359d9185...
==========

[commit-bot: I haz the power, 2017-03-31 00:12:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/26bd6d86d59d2c7227e4359d9185...