Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider_unittest.cc

Issue 2787143002: [Reland #1] macOS: Fix a bug in logic to get all memory regions. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/common/process_metrics_memory_dump_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/common/process_metrics_memory_dump_provider_unittest.cc
diff --git a/components/tracing/common/process_metrics_memory_dump_provider_unittest.cc b/components/tracing/common/process_metrics_memory_dump_provider_unittest.cc
index 77124349694d37b7869c4b1bdee00d4da19c2d92..b28d3f2aad691027a0f3483698d5f93cb9d998c4 100644
--- a/components/tracing/common/process_metrics_memory_dump_provider_unittest.cc
+++ b/components/tracing/common/process_metrics_memory_dump_provider_unittest.cc
@@ -410,28 +410,5 @@ TEST(ProcessMetricsMemoryDumpProviderTest, TestMachOReading) {
EXPECT_TRUE(found_appkit);
}
-TEST(ProcessMetricsMemoryDumpProviderTest, NoDuplicateRegions) {
- using VMRegion = base::trace_event::ProcessMemoryMaps::VMRegion;
- ProcessMetricsMemoryDumpProvider mdp(base::kNullProcessId);
- base::trace_event::MemoryDumpArgs args;
- base::trace_event::ProcessMemoryDump dump(nullptr, args);
- ASSERT_TRUE(mdp.DumpProcessMemoryMaps(args, &dump));
- ASSERT_TRUE(dump.has_process_mmaps());
-
- std::vector<VMRegion> regions;
- regions.reserve(dump.process_mmaps()->vm_regions().size());
- for (const VMRegion& region : dump.process_mmaps()->vm_regions())
- regions.push_back(region);
- std::sort(regions.begin(), regions.end(),
- [](const VMRegion& a, const VMRegion& b) -> bool {
- return a.start_address < b.start_address;
- });
- uint64_t last_address = 0;
- for (const VMRegion& region : regions) {
- EXPECT_GE(region.start_address, last_address);
- last_address = region.start_address + region.size_in_bytes;
- }
-}
-
#endif // defined(OS_MACOSX)
} // namespace tracing
« no previous file with comments | « components/tracing/common/process_metrics_memory_dump_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698