Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2787123002:
Update robust read pixels to output number of columns and rows written. (Closed)
|
Created:
3 years, 8 months ago by Geoff Lang Modified:
3 years, 6 months ago Reviewers:
piman CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate robust read pixels to output number of columns and rows written.
Allows the command buffer client to unpack the pixels without any code
changes when it knows which rows and columns were written to.
Roll ANGLE fe48632..bf67aa8
https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8
BUG=angleproject:1354
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2787123002
Cr-Commit-Position: refs/heads/master@{#462910}
Committed: https://chromium.googlesource.com/chromium/src/+/9afba497845bc3445b8a7d2736d3a564fe5121c7
Patch Set 1 #Patch Set 2 : Update binding mocks. #Patch Set 3 : Fix mock compile #Patch Set 4 : Roll ANGLE #Patch Set 5 : Reland with updated roll. #Patch Set 6 : Fix DEPS file #Patch Set 7 : Re-add WebGL2 GL tests. #
Messages
Total messages: 44 (33 generated)
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. BUG=angleproject:1354 ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by geofflang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
geofflang@chromium.org changed reviewers: + piman@chromium.org
PTAL
lgtm
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/2787123002/#ps60001 (title: "Roll ANGLE")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491333686985700,
"parent_rev": "a06f7d6c588c321df213d842c712e12ad6db7dec", "commit_rev":
"2751d5c8a72269724b6d3742a4619efe085bfc82"}
Message was sent while issue was closed.
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787123002 Cr-Commit-Position: refs/heads/master@{#461827} Committed: https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a461... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a461...
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2801783002/ by hans@chromium.org. The reason for reverting is: This broke the 32-bit Windows Clang build. See https://crbug.com/708591 There's a patch for Angle to fix it, so hopefully we can re-roll soon again. Unfortunately the breakage wasn't caught by trybots as the Win-Clang bot only does 64-bit builds..
Message was sent while issue was closed.
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787123002 Cr-Commit-Position: refs/heads/master@{#461827} Committed: https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a461... ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787123002 Cr-Commit-Position: refs/heads/master@{#461827} Committed: https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a461... ==========
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787123002 Cr-Commit-Position: refs/heads/master@{#461827} Committed: https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a461... ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE e93daba..e93daba https://chromium.googlesource.com/angle/angle.git/+log/e93daba..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE e93daba..e93daba https://chromium.googlesource.com/angle/angle.git/+log/e93daba..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/2787123002/#ps80001 (title: "Reland with updated roll.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by geofflang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..e93daba https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..bf67aa8 https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by geofflang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/2787123002/#ps100001 (title: "Fix DEPS file")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1491578747250410,
"parent_rev": "f801517c80bb21585875a5d413b46a8a3084c140", "commit_rev":
"9afba497845bc3445b8a7d2736d3a564fe5121c7"}
Message was sent while issue was closed.
Description was changed from ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..bf67aa8 https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Update robust read pixels to output number of columns and rows written. Allows the command buffer client to unpack the pixels without any code changes when it knows which rows and columns were written to. Roll ANGLE fe48632..bf67aa8 https://chromium.googlesource.com/angle/angle.git/+log/fe48632..bf67aa8 BUG=angleproject:1354 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2787123002 Cr-Commit-Position: refs/heads/master@{#462910} Committed: https://chromium.googlesource.com/chromium/src/+/9afba497845bc3445b8a7d2736d3... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/9afba497845bc3445b8a7d2736d3... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
