[ios] Dispatcher for tab_strip and tab_grid.

[ios] Dispatcher for tab_strip and tab_grid.

This CL implements the dispatcher in both tab_strip and tab_grid.
The tab_strip is now wired up to show/close tabs.

BUG=686770
Review-Url: https://codereview.chromium.org/2786893002
Cr-Commit-Position: refs/heads/master@{#460965}
Committed: https://chromium.googlesource.com/chromium/src/+/473015ab5e49f5b70ed66215cc94c9af87ca91b7

[edchin, 2017-03-30 06:07:29]

edchin@chromium.org changed reviewers:
+ lpromero@chromium.org, marq@chromium.org, sczs@chromium.org

[marq (ping after 24h), 2017-03-30 08:46:18]

LGTM once exception throw is changed.

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/commands/tab_strip_commands.h (right):

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/commands/tab_strip_commands.h:9: // (Commands are
for communicating into or within the coordinator layer).
This boilerplate comment is becoming less accurate; specifically we might want
to mention that commands should be routed via the dispatcher.

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
File
ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm
(right):

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm:64:
[NSException
We prefer not to raise ObjC exceptions (see
https://google.github.io/styleguide/objcguide.xml?showone=Avoid_Throwing_Exce...).
This is where NOTREACHED() should be used (from base/logging.h):

NOTREACHED() << "You must override " <<
base::SysNSStringToUTF8(NSStringFromSelector(_cmd)) << " in a subclass."

(you will need base/strings/sys_string_conversions.h as well).

[edchin, 2017-03-30 16:32:18]

The CQ bit was checked by edchin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 16:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:36:03]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[edchin, 2017-03-30 18:13:33]

The CQ bit was checked by edchin@chromium.org

[edchin, 2017-03-30 18:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2786893002/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-03-30 18:14:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[edchin, 2017-03-30 18:15:51]

Comments address. Now landing.

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/commands/tab_strip_commands.h (right):

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/commands/tab_strip_commands.h:9: // (Commands are
for communicating into or within the coordinator layer).
On 2017/03/30 08:46:18, marq wrote:
> This boilerplate comment is becoming less accurate; specifically we might want
> to mention that commands should be routed via the dispatcher.

Done. However, I did not mention the dispatcher
since this is simply an interface that can be used in any communications
architecture. Future proofing in the case we replace the underlying
architecture.

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
File
ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm
(right):

https://codereview.chromium.org/2786893002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tab_collection/tab_collection_view_controller.mm:64:
[NSException
On 2017/03/30 08:46:18, marq wrote:
> We prefer not to raise ObjC exceptions (see
>
https://google.github.io/styleguide/objcguide.xml?showone=Avoid_Throwing_Exce...).
> This is where NOTREACHED() should be used (from base/logging.h):
> 
> NOTREACHED() << "You must override " <<
> base::SysNSStringToUTF8(NSStringFromSelector(_cmd)) << " in a subclass."
> 
> (you will need base/strings/sys_string_conversions.h as well).

Done.

[commit-bot: I haz the power, 2017-03-30 18:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 18:24:54]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[edchin, 2017-03-30 18:47:28]

The CQ bit was checked by edchin@chromium.org

[edchin, 2017-03-30 18:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2786893002/#ps40001
(title: "Update showcase.")

[commit-bot: I haz the power, 2017-03-30 18:48:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 21:50:35]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[edchin, 2017-03-30 21:58:53]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:00:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[edchin, 2017-03-30 22:37:16]

The CQ bit was unchecked by edchin@chromium.org

[edchin, 2017-03-30 22:37:37]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2017-03-30 22:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[edchin, 2017-03-30 23:19:14]

The CQ bit was unchecked by edchin@chromium.org

[edchin, 2017-03-30 23:19:17]

The CQ bit was checked by edchin@chromium.org

[commit-bot: I haz the power, 2017-03-30 23:19:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 00:59:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490915957966930,
"parent_rev": "9d2815a109a6c3a6607d8f6a5bd61071d8ff60c1", "commit_rev":
"473015ab5e49f5b70ed66215cc94c9af87ca91b7"}

[commit-bot: I haz the power, 2017-03-31 01:00:26]

Description was changed from

==========
[ios] Dispatcher for tab_strip and tab_grid.

This CL implements the dispatcher in both tab_strip and tab_grid.
The tab_strip is now wired up to show/close tabs.

BUG=686770
==========

to

==========
[ios] Dispatcher for tab_strip and tab_grid.

This CL implements the dispatcher in both tab_strip and tab_grid.
The tab_strip is now wired up to show/close tabs.

BUG=686770

Review-Url: https://codereview.chromium.org/2786893002
Cr-Commit-Position: refs/heads/master@{#460965}
Committed:
https://chromium.googlesource.com/chromium/src/+/473015ab5e49f5b70ed66215cc94...
==========

[commit-bot: I haz the power, 2017-03-31 01:00:28]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/473015ab5e49f5b70ed66215cc94...