ios/clean/chrome/browser/ui/commands/tab_strip_commands.h - Issue 2786893002: [ios] Dispatcher for tab_strip and tab_grid.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/commands/tab_strip_commands.h

Issue 2786893002: [ios] Dispatcher for tab_strip and tab_grid. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TAB_STRIP_COMMANDS_H_

	6 #define IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TAB_STRIP_COMMANDS_H_

	7

	8 // Command protocol for commands relating to the tab strip UI.

	9 // (Commands are for communicating into or within the coordinator layer).
	marq (ping after 24h) 2017/03/30 08:46:18 This boilerplate comment is becoming less accurate This boilerplate comment is becoming less accurate; specifically we might want to mention that commands should be routed via the dispatcher. edchin 2017/03/30 18:15:51 Done. However, I did not mention the dispatcher si Show quoted text On 2017/03/30 08:46:18, marq wrote: > This boilerplate comment is becoming less accurate; specifically we might want > to mention that commands should be routed via the dispatcher. Done. However, I did not mention the dispatcher since this is simply an interface that can be used in any communications architecture. Future proofing in the case we replace the underlying architecture.
	10 @protocol TabStripCommands

	11

	12 // Display the tab corresponding to \|index\|.

	13 - (void)showTabStripTabAtIndex:(int)index;

	14

	15 // Remove tab corresponding to \|index\|.

	16 - (void)closeTabStripTabAtIndex:(int)index;

	17

	18 @end

	19

	20 #endif // IOS_CLEAN_CHROME_BROWSER_UI_COMMANDS_TAB_STRIP_COMMANDS_H_

OLD	NEW