Make HeapObjectHeader::checkHeader private.

Make HeapObjectHeader::checkHeader private.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030
Review-Url: https://codereview.chromium.org/2786843002
Cr-Commit-Position: refs/heads/master@{#461220}
Committed: https://chromium.googlesource.com/chromium/src/+/a459a6e71008ba58aaec1a9a95ac20b5864d5e82

[palmer, 2017-03-30 01:02:33]

palmer@chromium.org changed reviewers:
+ haraken@chromium.org

[palmer, 2017-03-30 01:04:04]

PTAL!

[palmer, 2017-03-30 01:04:13]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 01:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 03:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 03:07:58]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-03-30 14:12:46]

https://codereview.chromium.org/2786843002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h (right):

https://codereview.chromium.org/2786843002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/TraceWrapperMember.h:31:
(void)HeapObjectHeader::fromPayload(m_parent);

I'd prefer having HeapObjectHeader::checkHeader() instead of using (void)
though.

https://codereview.chromium.org/2786843002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/HeapPage.h (right):

https://codereview.chromium.org/2786843002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/HeapPage.h:847: CHECK(goodMagic);

What's a performance implication for the DCHECK => CHECK replacement?

[palmer, 2017-03-30 19:58:28]

> I'd prefer having HeapObjectHeader::checkHeader() instead of using (void)
though.

I'd really prefer to keep |checkHeader| private. I added |checkFromPayload|,
though; what do you think of that?

> What's a performance implication for the DCHECK => CHECK replacement?

Perf bot results on the way.

[haraken, 2017-03-31 00:02:20]

LGTM

On 2017/03/30 19:58:28, palmer wrote:
> > I'd prefer having HeapObjectHeader::checkHeader() instead of using (void)
> though.
> 
> I'd really prefer to keep |checkHeader| private. I added |checkFromPayload|,
> though; what do you think of that?
> 
> > What's a performance implication for the DCHECK => CHECK replacement?
> 
> Perf bot results on the way.

Can you factor out the DCHECK => CHECK change in a separate CL?

[palmer, 2017-03-31 00:13:33]

Description was changed from

==========
Make HeapObjectHeader::checkHeader private, and make it CHECK.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

CHECK instead of DCHECK: integrity/safety enforcement thus moves to production
builds.

BUG=633030
==========

to

==========
Make HeapObjectHeader::checkHeader private, and make it CHECK.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030
==========

[palmer, 2017-03-31 00:13:57]

> Can you factor out the DCHECK => CHECK change in a separate CL?

Done; follow-up CL coming right up.

[palmer, 2017-03-31 00:14:21]

Description was changed from

==========
Make HeapObjectHeader::checkHeader private, and make it CHECK.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030
==========

to

==========
Make HeapObjectHeader::checkHeader private.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030
==========

[palmer, 2017-03-31 00:14:25]

The CQ bit was checked by palmer@chromium.org

[palmer, 2017-03-31 00:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2786843002/#ps40001
(title: "Move back to DCHECK; will do CHECK in a follow-up CL.")

[commit-bot: I haz the power, 2017-03-31 00:15:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 01:45:05]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[palmer, 2017-03-31 19:41:18]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2017-03-31 19:41:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 20:53:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490989278428730,
"parent_rev": "feb86b8c5b8dd44f3baaae40e00c75c4e4012bc8", "commit_rev":
"a459a6e71008ba58aaec1a9a95ac20b5864d5e82"}

[commit-bot: I haz the power, 2017-03-31 20:54:03]

Description was changed from

==========
Make HeapObjectHeader::checkHeader private.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030
==========

to

==========
Make HeapObjectHeader::checkHeader private.

The function is properly private; callers should not have to 'know' when it's
necessary and when it isn't. It's the object's job to enforce its own internal
invariants.

BUG=633030

Review-Url: https://codereview.chromium.org/2786843002
Cr-Commit-Position: refs/heads/master@{#461220}
Committed:
https://chromium.googlesource.com/chromium/src/+/a459a6e71008ba58aaec1a9a95ac...
==========

[commit-bot: I haz the power, 2017-03-31 20:54:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a459a6e71008ba58aaec1a9a95ac...