third_party/WebKit/Source/platform/heap/GCInfo.cpp - Issue 2786843002: Make HeapObjectHeader::checkHeader private.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/GCInfo.cpp

Issue 2786843002: Make HeapObjectHeader::checkHeader private. (Closed)

Patch Set: Move back to DCHECK; will do CHECK in a follow-up CL. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/GCInfo.cpp

diff --git a/third_party/WebKit/Source/platform/heap/GCInfo.cpp b/third_party/WebKit/Source/platform/heap/GCInfo.cpp

index ce0c36c26f30232057cd2054d5877e90cdc2185a..e7ebe2c744834317c595c7e25f9cd0e61f110627 100644

--- a/third_party/WebKit/Source/platform/heap/GCInfo.cpp

+++ b/third_party/WebKit/Source/platform/heap/GCInfo.cpp

@@ -64,7 +64,7 @@ void GCInfoTable::init() {

#if DCHECK_IS_ON()

void assertObjectHasGCInfo(const void* payload, size_t gcInfoIndex) {

- HeapObjectHeader::fromPayload(payload)->checkHeader();

+ HeapObjectHeader::checkFromPayload(payload);

#if !defined(COMPONENT_BUILD)

// On component builds we cannot compare the gcInfos as they are statically

// defined in each of the components and hence will not match.