Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2786733005: Disable /analyze when building with clang (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable /analyze when building with clang When doing x64 builds of Chrome with VC++ we compile some modules (currently just libyuv) with clang, in order to get inline assembly support. This causes problems on /analyze builds because clang-cl doesn't understand the /analyze compiler switches. This change disables /analyze for those files that are compiled with clang. With this change I can do a /analyze build of libyuv without hitting any errors, but warnings are emitted as appropriate. R=brettw@chromium.org BUG=427616 Review-Url: https://codereview.chromium.org/2786733005 Cr-Commit-Position: refs/heads/master@{#460874} Committed: https://chromium.googlesource.com/chromium/src/+/bb4bb0ebf2bfc2881100122e1513ee3f694744a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/win/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
brucedawson
Your comment on the libyuv CL made me realize that the /analyze part of the ...
3 years, 8 months ago (2017-03-29 23:09:24 UTC) #4
brettw
lgtm
3 years, 8 months ago (2017-03-30 20:46:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786733005/1
3 years, 8 months ago (2017-03-30 20:56:36 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 21:07:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bb4bb0ebf2bfc2881100122e1513...

Powered by Google App Engine
This is Rietveld 408576698