Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: build/config/win/BUILD.gn

Issue 2786733005: Disable /analyze when building with clang (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/clang/clang.gni") 5 import("//build/config/clang/clang.gni")
6 import("//build/config/compiler/compiler.gni") 6 import("//build/config/compiler/compiler.gni")
7 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
8 import("//build/config/win/visual_studio_version.gni") 8 import("//build/config/win/visual_studio_version.gni")
9 import("//build/toolchain/toolchain.gni") 9 import("//build/toolchain/toolchain.gni")
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 arflags = [ 116 arflags = [
117 # "No public symbols found; archive member will be inaccessible." This 117 # "No public symbols found; archive member will be inaccessible." This
118 # means that one or more object files in the library can never be 118 # means that one or more object files in the library can never be
119 # pulled in to targets that link to this library. It's just a warning that 119 # pulled in to targets that link to this library. It's just a warning that
120 # the source file is a no-op. 120 # the source file is a no-op.
121 "/ignore:4221", 121 "/ignore:4221",
122 ] 122 ]
123 } 123 }
124 124
125 config("vs_code_analysis") { 125 config("vs_code_analysis") {
126 if (use_vs_code_analysis) { 126 if (use_vs_code_analysis && !is_clang) {
127 # When use_vs_code_analysis is specified add the /analyze switch to enable 127 # When use_vs_code_analysis is specified add the /analyze switch to enable
128 # static analysis. Specifying /analyze:WX- says that /analyze warnings 128 # static analysis. Specifying /analyze:WX- says that /analyze warnings
129 # should not be treated as errors. 129 # should not be treated as errors.
130 cflags = [ "/analyze:WX-" ] 130 cflags = [ "/analyze:WX-" ]
131 131
132 # Also, disable various noisy warnings that have low value. 132 # Also, disable various noisy warnings that have low value.
133 cflags += [ 133 cflags += [
134 "/wd6011", # Dereferencing NULL pointer 134 "/wd6011", # Dereferencing NULL pointer
135 135
136 # C6285 is ~16% of raw warnings and has low value 136 # C6285 is ~16% of raw warnings and has low value
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 413
414 # Internal stuff -------------------------------------------------------------- 414 # Internal stuff --------------------------------------------------------------
415 415
416 # Config used by the MIDL template to disable warnings. 416 # Config used by the MIDL template to disable warnings.
417 config("midl_warnings") { 417 config("midl_warnings") {
418 if (is_clang) { 418 if (is_clang) {
419 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_". 419 # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
420 cflags = [ "-Wno-extra-tokens" ] 420 cflags = [ "-Wno-extra-tokens" ]
421 } 421 }
422 } 422 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698