Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2786633002: Remove V8Future experiment. (Closed)

Created:
3 years, 8 months ago by rmcilroy
Modified:
3 years, 8 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, srahim+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove V8Future experiment. Removes the V8 Future experiment since it conflicts with the V8NoTurbo experiment and adds confusion as to how to enable / disable Ignition+ TurboFan. Also make the description for the V8NoTurbo about://flags entry clearer. BUG=chromium:703569, chromium:705476 Review-Url: https://codereview.chromium.org/2786633002 Cr-Commit-Position: refs/heads/master@{#460380} Committed: https://chromium.googlesource.com/chromium/src/+/124254af04fd234fffa434b8b4380f5056528e3b

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download
M gin/gin_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gin/public/gin_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M gin/v8_initializer.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
rmcilroy
Jochen, PTAL thanks.
3 years, 8 months ago (2017-03-29 11:00:23 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-03-29 11:02:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786633002/20001
3 years, 8 months ago (2017-03-29 14:26:10 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 14:31:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/124254af04fd234fffa434b8b438...

Powered by Google App Engine
This is Rietveld 408576698