Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: gin/v8_initializer.cc

Issue 2786633002: Remove V8Future experiment. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/public/gin_features.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/v8_initializer.h" 5 #include "gin/v8_initializer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 if (IsolateHolder::kStableAndExperimentalV8Extras == v8_extras_mode) { 364 if (IsolateHolder::kStableAndExperimentalV8Extras == v8_extras_mode) {
365 static const char flag[] = "--experimental_extras"; 365 static const char flag[] = "--experimental_extras";
366 v8::V8::SetFlagsFromString(flag, sizeof(flag) - 1); 366 v8::V8::SetFlagsFromString(flag, sizeof(flag) - 1);
367 } 367 }
368 368
369 const char* ignition_enabled_crash_key = "N"; 369 const char* ignition_enabled_crash_key = "N";
370 if (base::FeatureList::IsEnabled(features::kV8NoTurbo)) { 370 if (base::FeatureList::IsEnabled(features::kV8NoTurbo)) {
371 ignition_enabled_crash_key = "N"; 371 ignition_enabled_crash_key = "N";
372 std::string flag("--no-turbo"); 372 std::string flag("--no-turbo");
373 v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size())); 373 v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
374 } else if (base::FeatureList::IsEnabled(features::kV8Future)) {
375 ignition_enabled_crash_key = "Y";
376 std::string flag("--future");
377 v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
378 } else if (base::FeatureList::IsEnabled(features::kV8IgnitionLowEnd) && 374 } else if (base::FeatureList::IsEnabled(features::kV8IgnitionLowEnd) &&
379 base::SysInfo::IsLowEndDevice()) { 375 base::SysInfo::IsLowEndDevice()) {
380 ignition_enabled_crash_key = "Y"; 376 ignition_enabled_crash_key = "Y";
381 std::string flag("--ignition"); 377 std::string flag("--ignition");
382 v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size())); 378 v8::V8::SetFlagsFromString(flag.c_str(), static_cast<int>(flag.size()));
383 } 379 }
384 static const char kIgnitionEnabledKey[] = "v8-ignition"; 380 static const char kIgnitionEnabledKey[] = "v8-ignition";
385 base::debug::SetCrashKeyValue(kIgnitionEnabledKey, 381 base::debug::SetCrashKeyValue(kIgnitionEnabledKey,
386 ignition_enabled_crash_key); 382 ignition_enabled_crash_key);
387 383
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 *snapshot_data_out = 418 *snapshot_data_out =
423 reinterpret_cast<const char*>(g_mapped_snapshot->data()); 419 reinterpret_cast<const char*>(g_mapped_snapshot->data());
424 *snapshot_size_out = static_cast<int>(g_mapped_snapshot->length()); 420 *snapshot_size_out = static_cast<int>(g_mapped_snapshot->length());
425 } else { 421 } else {
426 *snapshot_data_out = NULL; 422 *snapshot_data_out = NULL;
427 *snapshot_size_out = 0; 423 *snapshot_size_out = 0;
428 } 424 }
429 } 425 }
430 426
431 } // namespace gin 427 } // namespace gin
OLDNEW
« no previous file with comments | « gin/public/gin_features.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698