Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2782483002: Disable -Wl,--gdb-index with LTO. (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
krasin1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable -Wl,--gdb-index with LTO. Follow-up to https://codereview.chromium.org/2770933009/ https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Linux_x64%2F17053%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout [1695/31073] LINK ./tls_edit FAILED: tls_edit tls_edit.map.gz python "../../build/toolchain/gcc_link_wrapper.py" --output="./tls_edit" --map-file "./tls_edit.map.gz" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -Wl,--icf=all -flto -fwhole-program-vtables -Wl,-plugin-opt,O1 -Wl,-plugin-opt,-function-sections -m64 -pthread -Werror -Wl,-O1 -Wl,--gc-sections -Wl,--gdb-index --sysroot=../../build/linux/debian_jessie_amd64-sysroot -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/lib/x86_64-linux-gnu -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/c/b/Google_Chrome_Linux_x64/src/build/linux/debian_jessie_amd64-sysroot/usr/lib -fsanitize=cfi-vcall -Wl,-rpath-link=. -Wl,--disable-new-dtags -o "./tls_edit" -Wl,--start-group @"./tls_edit.rsp" -Wl,--end-group -ldl -lrt ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info ../../third_party/binutils/Linux_x64/Release/bin/ld.gold: warning: /tmp/lto-llvm-0b5201.o: corrupt debug info in .debug_info BUG=none TBR=krasin Review-Url: https://codereview.chromium.org/2782483002 . Cr-Commit-Position: refs/heads/master@{#459866} Committed: https://chromium.googlesource.com/chromium/src/+/d9dbcf9e54cef6adb8f50288a6d907004cbfeb88

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
Nico
3 years, 9 months ago (2017-03-27 20:22:40 UTC) #3
Nico
Committed patchset #1 (id:1) manually as d9dbcf9e54cef6adb8f50288a6d907004cbfeb88 (tree was closed).
3 years, 9 months ago (2017-03-27 20:23:14 UTC) #5
krasin1
This breaks ThinLTO bots (may be some others too, unclear) https://codereview.chromium.org/2782483002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/2782483002/diff/1/build/config/compiler/BUILD.gn#newcode1669 ...
3 years, 8 months ago (2017-03-28 17:03:38 UTC) #6
krasin1
To be more correct, the other CL broke those bots, and this didn't fix it.
3 years, 8 months ago (2017-03-28 17:04:02 UTC) #7
Nico
On 2017/03/28 17:03:38, krasin1 wrote: > This breaks ThinLTO bots (may be some others too, ...
3 years, 8 months ago (2017-03-29 12:36:42 UTC) #8
krasin1
3 years, 8 months ago (2017-03-29 15:22:35 UTC) #9
Message was sent while issue was closed. 
On 2017/03/29 12:36:42, Nico wrote:
> On 2017/03/28 17:03:38, krasin1 wrote:
> > This breaks ThinLTO bots (may be some others too, unclear)
> > 
> >
>
https://codereview.chromium.org/2782483002/diff/1/build/config/compiler/BUILD.gn
> > File build/config/compiler/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/2782483002/diff/1/build/config/compiler/BUILD...
> > build/config/compiler/BUILD.gn:1669: !is_official_build) {
> > This is not probably what we want here. We need to add
> > !allow_posix_link_time_opt to fix LTO, but not official bots:
> >
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20ThinLTO%20Linux%20To...
> >
>
https://build.chromium.org/p/chromium.fyi/builders/ThinLTO%20Linux%20ToT/buil...
> 
> Want me to make a CL, or are you making one?
> 
> It's possible that I'm going to revert this whole -Wl,--gdb-index thing
> altogether in a day or two.

I have created one: https://codereview.chromium.org/2786603003/

Powered by Google App Engine
This is Rietveld 408576698