Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2786593002: Remove redundant WebLocalFrame* in runScriptsAtDocumentElementAvailable (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 679773f82aca83ced3397903a82c2e4dd7c899e6..2bbc711fe73035a26e196a354c71c434db52d212 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3841,9 +3841,7 @@ void RenderFrameImpl::didCreateDocumentElement(blink::WebLocalFrame* frame) {
observer.DidCreateDocumentElement(frame);
}
-void RenderFrameImpl::runScriptsAtDocumentElementAvailable(
- blink::WebLocalFrame* frame) {
- DCHECK(!frame_ || frame_ == frame);
+void RenderFrameImpl::runScriptsAtDocumentElementAvailable() {
base::WeakPtr<RenderFrameImpl> weak_self = weak_factory_.GetWeakPtr();
MojoBindingsController* mojo_bindings_controller =
@@ -3855,7 +3853,8 @@ void RenderFrameImpl::runScriptsAtDocumentElementAvailable(
return;
GetContentClient()->renderer()->RunScriptsAtDocumentStart(this);
- // Do not use |this| or |frame|! ContentClient might have deleted them by now!
+ // Do not use |this| or |frame_|! ContentClient might have deleted them by
+ // now!
}
void RenderFrameImpl::didReceiveTitle(blink::WebLocalFrame* frame,
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/LocalFrameClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698