Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2786583002: chromeos: Check both original and absolute paths for file: scheme (Closed)

Created:
3 years, 8 months ago by satorux1
Modified:
3 years, 6 months ago
CC:
benwells
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Check both original and absolute paths for file: scheme Previously, paths not in the whitelist were accessible through symbolic links via file: scheme. This patch solves this problem by checking both original and absolute paths (i.e. symbolic link is resolved with the latter). It is a known issue that this approach has a race between time to check the resolved path and time to read the path. BUG=677933 TEST=confirm that paths not in the whitelist cannot be accessed via symbolic links on Chrome OS CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2786583002 Cr-Commit-Position: refs/heads/master@{#475299} Committed: https://chromium.googlesource.com/chromium/src/+/ddac044c41e8b7a223c403e4574f5d44dff5e50e

Patch Set 1 : polish #

Patch Set 2 : check null #

Patch Set 3 : fix windows build #

Patch Set 4 : fix extensions tests #

Patch Set 5 : 2nd param #

Patch Set 6 : rebase #

Patch Set 7 : disable checks in sub classes #

Total comments: 21

Patch Set 8 : fixed a condition #

Patch Set 9 : rebase #

Patch Set 10 : check both paths by default #

Total comments: 2

Patch Set 11 : add a test for an empty path #

Patch Set 12 : remove debug logging #

Patch Set 13 : add null checks for network_delegate() #

Total comments: 6

Patch Set 14 : address comments #

Patch Set 15 : just rebase #

Patch Set 16 : Fix the PostTask usage after rebase #

Total comments: 8

Patch Set 17 : just rebase #

Patch Set 18 : debug logging #

Total comments: 2

Patch Set 19 : more logging for win bots debugging #

Patch Set 20 : Fix windows bots #

Patch Set 21 : remove logging and file the android build #

Patch Set 22 : rebase #

Patch Set 23 : Add logging for debugging Mac and Android bots... #

Patch Set 24 : Fix for Mac and Android bots #

Total comments: 28

Patch Set 25 : just rebase #

Patch Set 26 : address comments #

Total comments: 6

Patch Set 27 : address comment in the extensions/browser/extension_protocols.cc #

Patch Set 28 : absolute_path -> original_path #

Total comments: 2

Patch Set 29 : just rebase #

Patch Set 30 : remove dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -71 lines) Patch
M android_webview/browser/net/aw_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/browser/net/aw_network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_request_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/browser/cast_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M chromecast/browser/cast_network_delegate.cc View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_network_delegate.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/browser/extension_protocols.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 1 chunk +7 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M headless/lib/browser/headless_network_delegate.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/shell/shell_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/shell/shell_network_delegate.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M ios/web_view/internal/web_view_network_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ios/web_view/internal/web_view_network_delegate.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M net/base/directory_lister.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/base/directory_lister.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M net/base/layered_network_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +6 lines, -3 lines 0 comments Download
M net/base/layered_network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +9 lines, -6 lines 0 comments Download
M net/base/layered_network_delegate_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +7 lines, -4 lines 0 comments Download
M net/base/network_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +8 lines, -4 lines 0 comments Download
M net/base/network_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +3 lines, -2 lines 0 comments Download
M net/base/network_delegate_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -1 line 0 comments Download
M net/base/network_delegate_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +4 lines, -2 lines 0 comments Download
M net/proxy/network_delegate_error_observer_unittest.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 22 23 24 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/file_protocol_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -6 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +20 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 2 3 4 5 6 7 8 2 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +12 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_util.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_test_util.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 3 chunks +180 lines, -9 lines 0 comments Download

Messages

Total messages: 188 (134 generated)
mmenke
Sorry! I wrote some comments last week, but forgot to publish them (Maybe I wasn't ...
3 years, 8 months ago (2017-04-18 17:24:46 UTC) #58
satorux1
Matt, I was planning to polish before sending out for a code review, but thank ...
3 years, 8 months ago (2017-04-19 06:27:58 UTC) #59
satorux1
https://codereview.chromium.org/2786583002/diff/320001/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/2786583002/diff/320001/chrome/browser/net/chrome_network_delegate.cc#newcode471 chrome/browser/net/chrome_network_delegate.cc:471: const base::FilePath& path = original_path; Thanks. I'll ask jorgelo@ ...
3 years, 8 months ago (2017-04-19 07:22:23 UTC) #61
mmenke
https://codereview.chromium.org/2786583002/diff/320001/net/url_request/url_request_file_dir_job.cc File net/url_request/url_request_file_dir_job.cc (right): https://codereview.chromium.org/2786583002/diff/320001/net/url_request/url_request_file_dir_job.cc#newcode48 net/url_request/url_request_file_dir_job.cc:48: weak_factory_.GetWeakPtr())); On 2017/04/19 07:22:22, satorux1 wrote: > On 2017/04/18 ...
3 years, 8 months ago (2017-04-19 15:18:35 UTC) #62
satorux1
https://codereview.chromium.org/2786583002/diff/320001/net/url_request/url_request_file_dir_job.cc File net/url_request/url_request_file_dir_job.cc (right): https://codereview.chromium.org/2786583002/diff/320001/net/url_request/url_request_file_dir_job.cc#newcode48 net/url_request/url_request_file_dir_job.cc:48: weak_factory_.GetWeakPtr())); On 2017/04/19 15:18:35, mmenke wrote: > On 2017/04/19 ...
3 years, 8 months ago (2017-04-21 00:59:47 UTC) #63
satorux1
> As shown in Patch Set 1, this patch was much smaller originally, but got ...
3 years, 8 months ago (2017-04-21 01:04:01 UTC) #64
satorux1
On 2017/04/21 01:04:01, satorux1 wrote: > > As shown in Patch Set 1, this patch ...
3 years, 8 months ago (2017-04-21 06:27:45 UTC) #65
satorux1
https://codereview.chromium.org/2786583002/diff/320001/extensions/shell/browser/shell_network_delegate.cc File extensions/shell/browser/shell_network_delegate.cc (right): https://codereview.chromium.org/2786583002/diff/320001/extensions/shell/browser/shell_network_delegate.cc#newcode116 extensions/shell/browser/shell_network_delegate.cc:116: return true; On 2017/04/19 07:22:22, satorux1 wrote: > On ...
3 years, 8 months ago (2017-04-21 06:35:10 UTC) #66
satorux1
https://codereview.chromium.org/2786583002/diff/320001/net/base/network_delegate.h File net/base/network_delegate.h (right): https://codereview.chromium.org/2786583002/diff/320001/net/base/network_delegate.h#newcode274 net/base/network_delegate.h:274: // is allowed. On 2017/04/18 17:24:45, mmenke wrote: > ...
3 years, 8 months ago (2017-04-21 08:05:37 UTC) #71
mmenke
On 2017/04/21 06:27:45, satorux1 wrote: > On 2017/04/21 01:04:01, satorux1 wrote: > > > As ...
3 years, 8 months ago (2017-04-21 15:14:56 UTC) #78
satorux1
> I think checking both paths is better, in that it draws attention to symbolic ...
3 years, 7 months ago (2017-05-09 07:29:09 UTC) #79
satorux1
I think the patch is ready for review. PTAL https://codereview.chromium.org/2786583002/diff/320001/chrome/browser/net/chrome_network_delegate.cc File chrome/browser/net/chrome_network_delegate.cc (right): https://codereview.chromium.org/2786583002/diff/320001/chrome/browser/net/chrome_network_delegate.cc#newcode471 chrome/browser/net/chrome_network_delegate.cc:471: ...
3 years, 7 months ago (2017-05-09 07:44:09 UTC) #82
satorux1
3 years, 7 months ago (2017-05-09 07:46:14 UTC) #89
mmoroz
LGTM https://codereview.chromium.org/2786583002/diff/460001/net/base/directory_lister.cc File net/base/directory_lister.cc (right): https://codereview.chromium.org/2786583002/diff/460001/net/base/directory_lister.cc#newcode147 net/base/directory_lister.cc:147: data.absolute_path = base::MakeAbsoluteFilePath(path); Excuse me if this is ...
3 years, 7 months ago (2017-05-09 13:30:07 UTC) #93
satorux1
Just noticed that some tests were failing. I'll have a look. https://codereview.chromium.org/2786583002/diff/460001/net/base/directory_lister.cc File net/base/directory_lister.cc (right): ...
3 years, 7 months ago (2017-05-10 06:02:29 UTC) #94
satorux1
Just noticed that some tests were failing. I'll have a look. https://codereview.chromium.org/2786583002/diff/460001/net/base/directory_lister.cc File net/base/directory_lister.cc (right): ...
3 years, 7 months ago (2017-05-10 06:02:29 UTC) #95
satorux1
On 2017/05/10 06:02:29, satorux1 wrote: > Just noticed that some tests were failing. I'll have ...
3 years, 7 months ago (2017-05-10 07:49:17 UTC) #99
mmenke
https://codereview.chromium.org/2786583002/diff/540001/net/url_request/url_request_file_dir_job.cc File net/url_request/url_request_file_dir_job.cc (right): https://codereview.chromium.org/2786583002/diff/540001/net/url_request/url_request_file_dir_job.cc#newcode121 net/url_request/url_request_file_dir_job.cc:121: } I'm fine with this change, but I don't ...
3 years, 7 months ago (2017-05-10 18:03:32 UTC) #102
mmenke
One other question: Since this is considered a security issue, particularly on ChromeOS, should we ...
3 years, 7 months ago (2017-05-10 18:18:28 UTC) #103
satorux1
oops. the complilation is failing in the bots since I forgot to rebase. i don't ...
3 years, 7 months ago (2017-05-12 13:24:11 UTC) #108
satorux1
On 2017/05/10 18:18:28, mmenke wrote: > One other question: Since this is considered a security ...
3 years, 7 months ago (2017-05-12 13:28:32 UTC) #109
mmenke
https://codereview.chromium.org/2786583002/diff/600001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/600001/net/url_request/url_request_unittest.cc#newcode839 net/url_request/url_request_unittest.cc:839: class PickyNetworkDelegate : public TestNetworkDelegate { nit: Maybe CookieBlockingNetworkDelegate? ...
3 years, 7 months ago (2017-05-15 19:21:14 UTC) #114
satorux1
https://codereview.chromium.org/2786583002/diff/600001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/600001/net/url_request/url_request_unittest.cc#newcode839 net/url_request/url_request_unittest.cc:839: class PickyNetworkDelegate : public TestNetworkDelegate { On 2017/05/15 19:21:14, ...
3 years, 7 months ago (2017-05-19 07:02:53 UTC) #117
satorux1
https://codereview.chromium.org/2786583002/diff/640001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/640001/net/url_request/url_request_unittest.cc#newcode848 net/url_request/url_request_unittest.cc:848: LOG(ERROR) << "@@ AddToWhitelist: " << directory.value(); will remove ...
3 years, 7 months ago (2017-05-19 07:41:56 UTC) #118
satorux1
https://codereview.chromium.org/2786583002/diff/640001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/640001/net/url_request/url_request_unittest.cc#newcode848 net/url_request/url_request_unittest.cc:848: LOG(ERROR) << "@@ AddToWhitelist: " << directory.value(); On 2017/05/19 ...
3 years, 7 months ago (2017-05-19 13:11:42 UTC) #121
satorux1
Some more logging: [4912:5716:0521/220205.515:77161682:ERROR:url_request_unittest.cc(1128)] @@ temp_dir: C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4912_28556 [4912:5716:0521/220205.515:77161682:ERROR:url_request_unittest.cc(1132)] @@ absolute_temp_dir: C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4912_28556 [4912:5716:0521/220205.515:77161682:ERROR:url_request_unittest.cc(1135)] @@ test_file: C:\Users\chrome-bot\AppData\Local\Temp\scoped_dir4912_28556\4a398371-a91f-490e-abd5-6f051fcf5186.tmp ...
3 years, 7 months ago (2017-05-22 05:21:25 UTC) #122
satorux1
"For whatever reason" -> CreateTemporaryFileInDir() uses GetLongPathName(), that, I guess, expands CHROME~2 to chrome-bot. :P
3 years, 7 months ago (2017-05-22 05:42:49 UTC) #123
mmenke
Should file a bug against Windows. "GetLongPathName() does what it is specced to do"
3 years, 7 months ago (2017-05-22 15:10:38 UTC) #132
mmenke
Sorry for the delay! LGTM. I'm quite happy with this. https://codereview.chromium.org/2786583002/diff/760001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/760001/net/url_request/url_request_unittest.cc#newcode848 ...
3 years, 7 months ago (2017-05-24 19:25:51 UTC) #137
satorux1
https://codereview.chromium.org/2786583002/diff/760001/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2786583002/diff/760001/net/url_request/url_request_unittest.cc#newcode848 net/url_request/url_request_unittest.cc:848: LOG(ERROR) << "@@ AddToWhitelist: " << directory.value(); On 2017/05/24 ...
3 years, 7 months ago (2017-05-25 01:51:07 UTC) #140
satorux1
On 2017/05/24 19:25:51, mmenke wrote: > Sorry for the delay! LGTM. I'm quite happy with ...
3 years, 7 months ago (2017-05-25 01:57:12 UTC) #143
mmenke
On 2017/05/25 01:57:12, satorux1 wrote: > On 2017/05/24 19:25:51, mmenke wrote: > > Sorry for ...
3 years, 7 months ago (2017-05-25 03:07:10 UTC) #144
satorux1
PTAL! The changes to the following directories are mostly just to add |absolute_path| parameter to ...
3 years, 7 months ago (2017-05-25 03:46:01 UTC) #146
alokp
lgtm
3 years, 7 months ago (2017-05-25 04:04:53 UTC) #147
mmenke
satorux1: I own chrome/browser/net, so rather than using thestig, a top level chrome/ owner, you ...
3 years, 7 months ago (2017-05-25 04:07:17 UTC) #148
satorux1
mmenke: that's good point! PTAL: dewittj: chrome/browser/android/offline_pages thesig: none :)
3 years, 7 months ago (2017-05-25 04:09:31 UTC) #150
benwells
Sorry I don't know much about this particular extension class, punting to Devlin.
3 years, 7 months ago (2017-05-25 05:00:22 UTC) #152
Mike West
//content/shell LGTM
3 years, 7 months ago (2017-05-25 09:33:39 UTC) #155
Eugene But (OOO till 7-30)
ios lgtm
3 years, 7 months ago (2017-05-25 14:40:33 UTC) #156
Devlin
https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; What do |original_path| and |absolute_path| here look ...
3 years, 7 months ago (2017-05-25 15:06:31 UTC) #157
Torne
android_webview LGTM
3 years, 7 months ago (2017-05-25 16:30:38 UTC) #158
Sami
headless/ lgtm.
3 years, 7 months ago (2017-05-25 17:30:20 UTC) #159
Lei Zhang
I defer to jianli who wrote most of offline_page_request_job.cc.
3 years, 7 months ago (2017-05-25 21:07:16 UTC) #161
satorux1
Devlin, PTAL https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; On 2017/05/25 15:06:30, Devlin (catching ...
3 years, 7 months ago (2017-05-25 21:14:50 UTC) #162
Devlin
lgtm if there are no issues https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; On ...
3 years, 7 months ago (2017-05-26 00:55:36 UTC) #163
satorux1
To: Devlin https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; On 2017/05/26 00:55:36, Devlin (catching ...
3 years, 7 months ago (2017-05-26 03:28:39 UTC) #165
satorux1
jianli@, dewitt@: Could you take a loo at chrome/browser/android/offline_pages ? I think this is the ...
3 years, 7 months ago (2017-05-26 03:45:49 UTC) #167
satorux1
To: Devlin https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; On 2017/05/26 03:28:38, satorux1 wrote: ...
3 years, 7 months ago (2017-05-26 05:00:41 UTC) #170
jianli
offline_pages lgtm https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc File chrome/browser/android/offline_pages/offline_page_request_job.cc (right): https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc#newcode714 chrome/browser/android/offline_pages/offline_page_request_job.cc:714: return true; Though it is not relevant, ...
3 years, 7 months ago (2017-05-26 18:52:52 UTC) #175
mmenke
https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc File chrome/browser/android/offline_pages/offline_page_request_job.cc (right): https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc#newcode714 chrome/browser/android/offline_pages/offline_page_request_job.cc:714: return true; On 2017/05/26 18:52:52, jianli wrote: > Though ...
3 years, 7 months ago (2017-05-26 19:00:04 UTC) #176
jianli
On 2017/05/26 19:00:04, mmenke wrote: > https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc > File chrome/browser/android/offline_pages/offline_page_request_job.cc (right): > > https://codereview.chromium.org/2786583002/diff/840001/chrome/browser/android/offline_pages/offline_page_request_job.cc#newcode714 > ...
3 years, 7 months ago (2017-05-26 19:46:51 UTC) #177
satorux1
https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc File extensions/browser/extension_protocols.cc (right): https://codereview.chromium.org/2786583002/diff/800001/extensions/browser/extension_protocols.cc#newcode291 extensions/browser/extension_protocols.cc:291: return true; > I'm guessing that |directory_path_| contains a ...
3 years, 6 months ago (2017-05-29 03:36:16 UTC) #180
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786583002/880001
3 years, 6 months ago (2017-05-29 06:01:10 UTC) #185
commit-bot: I haz the power
3 years, 6 months ago (2017-05-29 06:06:38 UTC) #188
Message was sent while issue was closed.
Committed patchset #30 (id:880001) as
https://chromium.googlesource.com/chromium/src/+/ddac044c41e8b7a223c403e4574f...

Powered by Google App Engine
This is Rietveld 408576698