chromeos: Check both original and absolute paths for file: scheme

chrome/browser/android/offline_pages/offline_page_request_job.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 689 matching lines @@
                          redirected_url.spec().c_str());
 
   fake_headers_for_redirect_ = new net::HttpResponseHeaders(
       net::HttpUtil::AssembleRawHeaders(header_string.c_str(),
                                         header_string.length()));
   DCHECK(fake_headers_for_redirect_->IsRedirect(nullptr));
 
   URLRequestJob::NotifyHeadersComplete();
 }
 
+// Returns true to disable the file path checking for file: scheme in
+// URLRequestFileJob, that's not relevant for this class.
+bool OfflinePageRequestJob::CanAccessFile(const base::FilePath& original_path,
+                                          const base::FilePath& absolute_path) {
+  return true;

[jianli, 2017/05/26 18:52:52]

Though it is not relevant, will returning false be a bit safer?

[mmenke, 2017/05/26 19:00:04]

Wouldn't that break this class entirely?  This subclasses URLRequestFileJob, and
requires access to whatever file it's mapping a request to.  If it can't access
that file, it won't work.

+}
+
 void OfflinePageRequestJob::SetDelegateForTesting(
     std::unique_ptr<Delegate> delegate) {
   delegate_ = std::move(delegate);
 }
 
 }  // namespace offline_pages