Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2786443003: Revert "Destroy the old RenderWidgetHostView when swapping out a main frame." (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 921ece3ec8a7e47f39bdfae3480d418ef9b0184f..5a575e24401eb517528a21514727196c99722af2 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4983,16 +4983,11 @@ bool WebContentsImpl::CreateRenderViewForRenderManager(
TRACE_EVENT0("browser,navigation",
"WebContentsImpl::CreateRenderViewForRenderManager");
- RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(render_view_host);
-
- // We only create a RWHV for active RenderViewHosts. When an inactive RVH is
- // reused, the RWHV is created in RenderFrameHostManager::CommitPending.
- if (rvhi->is_active()) {
- DCHECK_EQ(MSG_ROUTING_NONE, proxy_routing_id);
+ if (proxy_routing_id == MSG_ROUTING_NONE)
CreateRenderWidgetHostViewForRenderManager(render_view_host);
- }
- if (!rvhi->CreateRenderView(opener_frame_routing_id, proxy_routing_id,
+ if (!static_cast<RenderViewHostImpl*>(render_view_host)
+ ->CreateRenderView(opener_frame_routing_id, proxy_routing_id,
replicated_frame_state, created_with_opener_)) {
return false;
}
« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698