Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2786313004: Enable warning on reserved user-defined literals for CrOS. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable warning on reserved user-defined literals for CrOS. This was blocked on making CrOS use the jessie sysroot, which is now done. BUG=263960 Review-Url: https://codereview.chromium.org/2786313004 Cr-Commit-Position: refs/heads/master@{#461149} Committed: https://chromium.googlesource.com/chromium/src/+/b3fc618111c6c50e9e05a8afb72f6fb40fd3b585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
Nico
3 years, 8 months ago (2017-03-31 11:33:48 UTC) #4
dcheng
lgtm
3 years, 8 months ago (2017-03-31 16:27:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786313004/1
3 years, 8 months ago (2017-03-31 16:35:30 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 16:49:42 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3fc618111c6c50e9e05a8afb72f...

Powered by Google App Engine
This is Rietveld 408576698