Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2786313004: Enable warning on reserved user-defined literals for CrOS. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 878ec588c89036b8bb3bed1e321b30031ac0b47d..8429177020d25f119bea42aff791f02580e0340f 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1035,18 +1035,9 @@ config("default_warnings") {
]
}
- if (is_chromeos) {
- # TODO(thakis): Remove, http://crbug.com/263960
- if (is_clang) {
- cflags_cc += [ "-Wno-reserved-user-defined-literal" ]
-
- # TODO(thakis): Enable this, crbug.com/507717
- if (!is_nacl) {
- cflags += [ "-Wno-shift-negative-value" ]
- }
- } else {
- cflags_cc += [ "-Wno-literal-suffix" ]
- }
+ if (is_chromeos && is_clang && !is_nacl) {
+ # TODO(thakis): Enable this, crbug.com/507717
+ cflags += [ "-Wno-shift-negative-value" ]
}
if (is_clang) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698