Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issue 2786273002: Revert of Enable -Wdeprecated-register (except on CrOS). (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable -Wdeprecated-register (except on CrOS). (patchset #7 id:120001 of https://codereview.chromium.org/2780623003/ ) Reason for revert: Findit identified CL at revision 460879 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E0Njg3MmNhOTZkODYyODE2Zjk5M2MxNmQ2YzI3MGFmMjYyOTAyNDcM Original issue's description: > Enable -Wdeprecated-register (except on CrOS). > > No behavior change. > > BUG=255186, 705812 > > Review-Url: https://codereview.chromium.org/2780623003 > Cr-Original-Commit-Position: refs/heads/master@{#459973} > Committed: https://chromium.googlesource.com/chromium/src/+/76ad12fee73e4512dbb9c7a79ffb6cec33fae6f2 > Review-Url: https://codereview.chromium.org/2780623003 > Cr-Commit-Position: refs/heads/master@{#460879} > Committed: https://chromium.googlesource.com/chromium/src/+/a46872ca96d862816f993c16d6c270af26290247 TBR=dcheng@chromium.org,rouslan@chromium.org,kbr@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=255186, 705812 Review-Url: https://codereview.chromium.org/2786273002 Cr-Commit-Position: refs/heads/master@{#460910} Committed: https://chromium.googlesource.com/chromium/src/+/0c64e3912571118d628f513ccc3a7eb6224099d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -133 lines) Patch
M base/third_party/dmg_fp/README.chromium View 1 chunk +0 lines, -1 line 0 comments Download
M base/third_party/dmg_fp/g_fmt.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_css_property_names.py View 2 chunks +48 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_css_value_keywords.py View 2 chunks +17 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/platform/ColorData.gperf View 2 chunks +3 lines, -14 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 6 chunks +7 lines, -21 lines 0 comments Download
M third_party/mesa/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
findit-for-me
Created Revert of Enable -Wdeprecated-register (except on CrOS).
3 years, 8 months ago (2017-03-30 22:49:15 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-03-30 22:49:18 UTC) #3
ortuno
lgtm
3 years, 8 months ago (2017-03-30 22:50:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786273002/1
3 years, 8 months ago (2017-03-30 22:51:38 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 22:53:50 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c64e3912571118d628f513ccc3a...

Powered by Google App Engine
This is Rietveld 408576698