Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2786173004: Revert of Remove download_binaries.py from DEPS (Closed)

Created:
3 years, 8 months ago by Tom Anderson
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Dirk Pranke
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove download_binaries.py from DEPS (patchset #2 id:20001 of https://codereview.chromium.org/2774043002/ ) Reason for revert: https://codereview.chromium.org/2775913002/ needs to be reverted, so reverting all dependent patch sets Original issue's description: > Remove download_binaries.py from DEPS > > This step is no longer necessary after https://codereview.chromium.org/2775913002/ > > BUG=chromium:705072 > > Review-Url: https://codereview.chromium.org/2774043002 > Cr-Commit-Position: refs/heads/master@{#44252} > Committed: https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c785a1c TBR=machenbach@chromium.org,thomasanderson@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:705072 Review-Url: https://codereview.chromium.org/2786173004 Cr-Commit-Position: refs/heads/master@{#44289} Committed: https://chromium.googlesource.com/v8/v8/+/3b72184d40abde9c70149783189eb77c7438dc4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M DEPS View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom Anderson
Created Revert of Remove download_binaries.py from DEPS
3 years, 8 months ago (2017-03-31 00:29:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786173004/1
3 years, 8 months ago (2017-03-31 00:29:25 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-31 00:29:27 UTC) #5
Michael Achenbach
lgtm
3 years, 8 months ago (2017-03-31 06:31:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786173004/1
3 years, 8 months ago (2017-03-31 06:31:59 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 07:34:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3b72184d40abde9c70149783189eb77c743...

Powered by Google App Engine
This is Rietveld 408576698