Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2774043002:
Remove download_binaries.py from DEPS (Closed)
|
Created:
3 years, 9 months ago by Tom (Use chromium acct) Modified:
3 years, 8 months ago Reviewers:
Michael Achenbach CC:
v8-reviews_googlegroups.com, Dirk Pranke Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
DescriptionRemove download_binaries.py from DEPS
This step is no longer necessary after https://codereview.chromium.org/2775913002/
BUG=chromium:705072
Review-Url: https://codereview.chromium.org/2774043002
Cr-Commit-Position: refs/heads/master@{#44252}
Committed: https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c785a1c
Patch Set 1 #Patch Set 2 : roll instrumented libraries version #Messages
Total messages: 24 (19 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thomasanderson@google.com changed reviewers: + marja@chromium.org
marja@ ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37765)
Description was changed from ========== Remove download_binaries.py from DEPS This step is no longer necessary after https://codereview.chromium.org/2775913002/ BUG=705072 ========== to ========== Remove download_binaries.py from DEPS This step is no longer necessary after https://codereview.chromium.org/2775913002/ BUG=chromium:705072 ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org - marja@chromium.org
lgtm if Dirk is ok with comment https://bugs.chromium.org/p/chromium/issues/detail?id=705072#c2
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from machenbach@chromium.org Link to the patchset: https://codereview.chromium.org/2774043002/#ps20001 (title: "roll instrumented libraries version")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490823719584100,
"parent_rev": "3ab262774a2825879c0363c4681510ec7b62c6e5", "commit_rev":
"459b881c233557f5da9ca9e4779fc1696c785a1c"}
Message was sent while issue was closed.
Description was changed from ========== Remove download_binaries.py from DEPS This step is no longer necessary after https://codereview.chromium.org/2775913002/ BUG=chromium:705072 ========== to ========== Remove download_binaries.py from DEPS This step is no longer necessary after https://codereview.chromium.org/2775913002/ BUG=chromium:705072 Review-Url: https://codereview.chromium.org/2774043002 Cr-Commit-Position: refs/heads/master@{#44252} Committed: https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/459b881c233557f5da9ca9e4779fc1696c7...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2786173004/ by thomasanderson@chromium.org. The reason for reverting is: https://codereview.chromium.org/2775913002/ needs to be reverted, so reverting all dependent patch sets. |
