Prepare for separate setter scope.

Prepare for separate setter scope.

R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/5fcbc900a6ad67d6b84f21d3f5a4cb7c4be93e0f

[ahe, 2017-03-31 14:43:32]

ahe@google.com changed reviewers:
+ karlklose@google.com

[ahe, 2017-03-31 14:43:32]

It will all make sense soon :-)

[karlklose, 2017-04-03 06:28:52]

LGTM with a comment.

https://codereview.chromium.org/2788913002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2788913002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:199: /// (and not a
setter).
'(and not a setter)' -> 'and is not a setter'.

Is it necessary that this is the []-operator? Since this method is for special
cases only, I would give it a name documenting the purpose if possible.

[ahe, 2017-04-04 09:41:33]

Thank you, Karl!

https://codereview.chromium.org/2788913002/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/builder/class_builder.dart (right):

https://codereview.chromium.org/2788913002/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/builder/class_builder.dart:199: /// (and not a
setter).
On 2017/04/03 06:28:52, karlklose wrote:
> '(and not a setter)' -> 'and is not a setter'.

Done.

> Is it necessary that this is the []-operator? Since this method is for special
> cases only, I would give it a name documenting the purpose if possible.

I have a bunch of changes on top of this, so I'll add a TODO to rename it to
getLocalMember.

[ahe, 2017-04-04 10:20:22]

Description was changed from

==========
Prepare for separate setter scope.
==========

to

==========
Prepare for separate setter scope.

R=karlklose@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5fcbc900a6ad67d6b84f21d3f5a4cb7c4be93e0f
==========

[ahe, 2017-04-04 10:20:24]

Committed patchset #4 (id:60001) manually as
5fcbc900a6ad67d6b84f21d3f5a4cb7c4be93e0f (presubmit successful).