chrome/browser/extensions/api/proxy/proxy_api_helpers.h - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api_helpers.h

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_api_helpers.h

diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers.h b/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

index 26b9a9c6efbc7266939b92df4a2a1bfd0a9f6a5d..1f688210a331faddf26d983597949ec500b61ab5 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers.h

@@ -78,7 +78,7 @@ bool GetBypassListFromExtensionPref(const base::DictionaryValue* proxy_config,

// Creates and returns a ProxyConfig dictionary (as defined in the extension

// API) from the given parameters. Ownership is passed to the caller.

// Depending on the value of |mode_enum|, several of the strings may be empty.

-base::DictionaryValue* CreateProxyConfigDict(

+std::unique_ptr<base::DictionaryValue> CreateProxyConfigDict(

ProxyPrefs::ProxyMode mode_enum,

bool pac_mandatory,

const std::string& pac_url,