chromeos/network/proxy/ui_proxy_config.h - Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/proxy/ui_proxy_config.h

Issue 2785883003: Use unique_ptr<DictionaryValue> in ProxyConfigDictionary (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/proxy/ui_proxy_config.h

diff --git a/chromeos/network/proxy/ui_proxy_config.h b/chromeos/network/proxy/ui_proxy_config.h

index 4338a39b67bc7b081b16e9e705c0b63e597a12f1..705519181a8cbee954300ed7ed581693569abdf6 100644

--- a/chromeos/network/proxy/ui_proxy_config.h

+++ b/chromeos/network/proxy/ui_proxy_config.h

@@ -74,7 +74,7 @@ struct CHROMEOS_EXPORT UIProxyConfig {

// Converts |this| to Dictionary of ProxyConfigDictionary format (which

// is the same format used by prefs).

- base::DictionaryValue* ToPrefProxyConfig() const;

+ std::unique_ptr<base::DictionaryValue> ToPrefProxyConfig() const;

// Map |scheme| (one of "http", "https", "ftp" or "socks") to the correct

// ManualProxy. Returns NULL if scheme is invalid.