Use unique_ptr<DictionaryValue> in ProxyConfigDictionary

chrome/browser/extensions/api/proxy/proxy_api_helpers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Definition of helper functions for the Chrome Extensions Proxy Settings API.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_HELPERS_H_
 #define CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_HELPERS_H_
 
 #include <string>

[jdoerrie, 2017/03/30 11:00:39]

nit: add #include <memory>

[vabr (Chromium), 2017/03/30 12:07:41]

Done.

 
 #include "components/proxy_config/proxy_prefs.h"
 #include "net/proxy/proxy_config.h"
 
 class ProxyConfigDictionary;
 
 namespace base {
 class DictionaryValue;
 class ListValue;
 }
@@ skipping 50 matching lines @@
     std::string* error,
     bool* bad_message);
 bool GetBypassListFromExtensionPref(const base::DictionaryValue* proxy_config,
                                     std::string* out,
                                     std::string* error,
                                     bool* bad_message);
 
 // Creates and returns a ProxyConfig dictionary (as defined in the extension
 // API) from the given parameters. Ownership is passed to the caller.
 // Depending on the value of |mode_enum|, several of the strings may be empty.
-base::DictionaryValue* CreateProxyConfigDict(
+std::unique_ptr<base::DictionaryValue> CreateProxyConfigDict(
     ProxyPrefs::ProxyMode mode_enum,
     bool pac_mandatory,
     const std::string& pac_url,
     const std::string& pac_data,
     const std::string& proxy_rules_string,
     const std::string& bypass_list,
     std::string* error);
 
 // Converts a ProxyServer dictionary instance (as defined in the extension API)
 // |proxy_server| to a net::ProxyServer.
@@ skipping 36 matching lines @@
 
 // Tokenizes the |in| at delimiters |delims| and returns a new ListValue with
 // StringValues created from the tokens. Ownership is passed to the caller.
 base::ListValue* TokenizeToStringList(const std::string& in,
                                       const std::string& delims);
 
 }  // namespace proxy_api_helpers
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_HELPERS_H_