Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2785483002: Reland of V2 of //tools/binary_size rewrite (diffs). (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of V2 of //tools/binary_size rewrite (diffs). Reverted in: https://codereview.chromium.org/2778963003/ Reason for reland: Fixed typo in Diff() command. Renames: analyze.py -> map2size.py symbols.py -> models.py query.py -> console.py mapfileparser.py -> linker_map_parser.py Main features: * Removes explain_binary_size_delta.py in favour of console.py. * Ability to diff two .size results. * Many improvements to console.py. * Added some integration tests. TBR=estevenson@chromium.org NOTRY=true BUG=681694 Review-Url: https://codereview.chromium.org/2785483002 Cr-Commit-Position: refs/heads/master@{#460088} Committed: https://chromium.googlesource.com/chromium/src/+/df30c0f4735e673c03e43a0c77eec1ee5cdd9653

Patch Set 1 #

Patch Set 2 : add missing name= #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1385 lines, -2316 lines) Patch
M tools/binary_size/README.md View 1 2 chunks +17 lines, -15 lines 0 comments Download
D tools/binary_size/analyze.py View 1 chunk +0 lines, -356 lines 0 comments Download
D tools/binary_size/binary_size_utils.py View 1 chunk +0 lines, -71 lines 0 comments Download
A tools/binary_size/console.py View 1 chunk +189 lines, -0 lines 0 comments Download
M tools/binary_size/create_html_breakdown.py View 1 7 chunks +20 lines, -17 lines 0 comments Download
A tools/binary_size/describe.py View 1 chunk +139 lines, -0 lines 0 comments Download
D tools/binary_size/explain_binary_size_delta.py View 1 chunk +0 lines, -484 lines 0 comments Download
D tools/binary_size/explain_binary_size_delta_unittest.py View 1 chunk +0 lines, -621 lines 0 comments Download
A tools/binary_size/file_format.py View 1 chunk +85 lines, -0 lines 0 comments Download
M tools/binary_size/function_signature_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/binary_size/helpers.py View 1 2 chunks +2 lines, -3 lines 0 comments Download
A tools/binary_size/integration_test.py View 1 chunk +114 lines, -0 lines 0 comments Download
A + tools/binary_size/linker_map_parser.py View 1 7 chunks +39 lines, -37 lines 0 comments Download
A + tools/binary_size/map2size.py View 1 8 chunks +55 lines, -163 lines 0 comments Download
D tools/binary_size/mapfileparser.py View 1 chunk +0 lines, -207 lines 0 comments Download
A tools/binary_size/models.py View 1 1 chunk +401 lines, -0 lines 0 comments Download
D tools/binary_size/query.py View 1 chunk +0 lines, -134 lines 0 comments Download
D tools/binary_size/symbols.py View 1 chunk +0 lines, -207 lines 0 comments Download
A tools/binary_size/testdata/ActualDiff.golden View 1 chunk +17 lines, -0 lines 0 comments Download
A tools/binary_size/testdata/ConsoleNullDiff.golden View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/binary_size/testdata/Map2Size.golden View 1 chunk +45 lines, -0 lines 0 comments Download
A tools/binary_size/testdata/test.map View 1 chunk +251 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (4 generated)
agrieve
Created Reland of V2 of //tools/binary_size rewrite (diffs).
3 years, 8 months ago (2017-03-28 13:58:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785483002/290001
3 years, 8 months ago (2017-03-28 14:03:46 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 14:10:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/chromium/src/+/df30c0f4735e673c03e43a0c77ee...

Powered by Google App Engine
This is Rietveld 408576698