Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2778963003: Revert of V2 of //tools/binary_size rewrite (diffs). (Closed)

Created:
3 years, 8 months ago by agrieve
Modified:
3 years, 8 months ago
Reviewers:
estevenson
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of V2 of //tools/binary_size rewrite (diffs). (patchset #7 id:120001 of https://codereview.chromium.org/2769933002/ ) Reason for revert: Typo'ed in final set of review comments :( Original issue's description: > V2 of //tools/binary_size rewrite (diffs). > > Renames: > analyze.py -> map2size.py > symbols.py -> models.py > query.py -> console.py > mapfileparser.py -> linker_map_parser.py > > Main features: > * Removes explain_binary_size_delta.py in favour of console.py. > * Ability to diff two .size results. > * Many improvements to console.py. > * Added some integration tests. > > BUG=681694 > > Review-Url: https://codereview.chromium.org/2769933002 > Cr-Commit-Position: refs/heads/master@{#459878} > Committed: https://chromium.googlesource.com/chromium/src/+/35ed9edd145d324bdec5c10a1f99c5863b93b775 TBR=estevenson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=681694 Review-Url: https://codereview.chromium.org/2778963003 Cr-Commit-Position: refs/heads/master@{#460083} Committed: https://chromium.googlesource.com/chromium/src/+/c2c38dc205e4ecce6a316deeaddd41c03a502cd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2117 lines, -1749 lines) Patch
M tools/binary_size/README.md View 2 chunks +15 lines, -17 lines 0 comments Download
A tools/binary_size/analyze.py View 1 chunk +356 lines, -0 lines 0 comments Download
A tools/binary_size/binary_size_utils.py View 1 chunk +71 lines, -0 lines 0 comments Download
D tools/binary_size/console.py View 1 chunk +0 lines, -189 lines 0 comments Download
M tools/binary_size/create_html_breakdown.py View 7 chunks +18 lines, -21 lines 0 comments Download
D tools/binary_size/describe.py View 1 chunk +0 lines, -139 lines 0 comments Download
A tools/binary_size/explain_binary_size_delta.py View 1 chunk +484 lines, -0 lines 0 comments Download
A tools/binary_size/explain_binary_size_delta_unittest.py View 1 chunk +621 lines, -0 lines 0 comments Download
D tools/binary_size/file_format.py View 1 chunk +0 lines, -85 lines 0 comments Download
M tools/binary_size/function_signature_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/binary_size/helpers.py View 2 chunks +3 lines, -2 lines 0 comments Download
D tools/binary_size/integration_test.py View 1 chunk +0 lines, -114 lines 0 comments Download
D tools/binary_size/linker_map_parser.py View 1 chunk +0 lines, -209 lines 0 comments Download
D tools/binary_size/map2size.py View 1 chunk +0 lines, -248 lines 0 comments Download
A tools/binary_size/mapfileparser.py View 1 chunk +207 lines, -0 lines 0 comments Download
D tools/binary_size/models.py View 1 chunk +0 lines, -401 lines 0 comments Download
A tools/binary_size/query.py View 1 chunk +134 lines, -0 lines 0 comments Download
A tools/binary_size/symbols.py View 1 chunk +207 lines, -0 lines 0 comments Download
D tools/binary_size/testdata/ActualDiff.golden View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/binary_size/testdata/ConsoleNullDiff.golden View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/binary_size/testdata/Map2Size.golden View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/binary_size/testdata/test.map View 1 chunk +0 lines, -251 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
agrieve
Created Revert of V2 of //tools/binary_size rewrite (diffs).
3 years, 8 months ago (2017-03-28 13:50:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2778963003/1
3 years, 8 months ago (2017-03-28 13:50:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c2c38dc205e4ecce6a316deeaddd41c03a502cd7
3 years, 8 months ago (2017-03-28 13:52:40 UTC) #6
agrieve
3 years, 8 months ago (2017-03-28 13:58:29 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2785483002/ by agrieve@chromium.org.

The reason for reverting is: reland in progress.

Powered by Google App Engine
This is Rietveld 408576698