[wrapper-tracing] Emite write barrier upon associating a wrapper

[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490
Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)

Review-Url: https://codereview.chromium.org/2785423002 .
Cr-Commit-Position: refs/branch-heads/2987@{#900}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/ba0f387f04ae5673c6360611fc1bb2bff9a73b24

[Michael Lippautz, 2017-03-31 07:56:24]

Description was changed from

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)

Review-Url: https://codereview.chromium.org/2783203002 .
Cr-Commit-Position: refs/branch-heads/2987@{#896}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/24f8804aa139486723395483bda7...

patch from issue 2783203002 at patchset 1 (http://crrev.com/2783203002#ps1)
==========

to

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)
==========

[Michael Lippautz, 2017-03-31 08:00:18]

PS1->PS2 shows the fix that is required to build on M57.

[Michael Lippautz, 2017-03-31 08:00:18]

PS1->PS2 shows the fix that is required to build on M57.

[Michael Lippautz, 2017-03-31 08:10:16]

Description was changed from

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)
==========

to

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)

Review-Url: https://codereview.chromium.org/2785423002 .
Cr-Commit-Position: refs/branch-heads/2987@{#900}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba0f387f04ae5673c6360611fc1b...
==========

[Michael Lippautz, 2017-03-31 08:10:17]

Committed patchset #2 (id:20001) manually as
ba0f387f04ae5673c6360611fc1bb2bff9a73b24.

[haraken, 2017-03-31 08:13:38]

LGTM