[wrapper-tracing] Emite write barrier upon associating a wrapper

[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490
Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)

Review-Url: https://codereview.chromium.org/2783203002 .
Cr-Commit-Position: refs/branch-heads/2987@{#896}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/24f8804aa139486723395483bda7015d3c57e1b2

[Michael Lippautz, 2017-03-30 14:11:29]

Description was changed from

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)
==========

to

==========
[wrapper-tracing] Emite write barrier upon associating a wrapper

Whenever we assign a reference that should be traced into V8 we need to
emit a write barrier. We automatically emit write barriers for
TraceWrapperv8Reference. However, we still use a regular (weak)
Persistent in ScriptWrappable, so we need to emit the barrier there
manually.

A follow up should convert the reference in ScriptWrappable to
TraceWrapperv8Reference.

BUG=chromium:702490

Review-Url: https://codereview.chromium.org/2759243002
Cr-Commit-Position: refs/heads/master@{#458357}
(cherry picked from commit a2011780ffefd6f9c120b80651015b3f6646244b)

Review-Url: https://codereview.chromium.org/2783203002 .
Cr-Commit-Position: refs/branch-heads/2987@{#896}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/24f8804aa139486723395483bda7...
==========

[Michael Lippautz, 2017-03-30 14:11:30]

Committed patchset #1 (id:1) manually as
24f8804aa139486723395483bda7015d3c57e1b2.

[Michael Moss, 2017-03-31 01:02:57]

mmoss@chromium.org changed reviewers:
+ mmoss@chromium.org

[Michael Moss, 2017-03-31 01:02:57]

I believe this is causing compile failures on the official builders, e.g.:

https://uberchromegw.corp.google.com/i/official.desktop/builders/win-pgo/buil...

src\third_party\webkit\source\bindings\core\v8\scriptwrappablevisitor.h(11):
fatal error C1083: Cannot open include file: 'platform/heap/VisitorImpl.h': No
such file or directory

[Michael Moss, 2017-03-31 01:06:40]

On 2017/03/31 01:02:57, Michael Moss wrote:
> I believe this is causing compile failures on the official builders, e.g.:
> 
>
https://uberchromegw.corp.google.com/i/official.desktop/builders/win-pgo/buil...
> 
> src\third_party\webkit\source\bindings\core\v8\scriptwrappablevisitor.h(11):
> fatal error C1083: Cannot open include file: 'platform/heap/VisitorImpl.h': No
> such file or directory

Looks like the failure was already noted in crbug.com/706985. Not sure why it
hasn't been reverted yet.

[Michael Lippautz, 2017-03-31 07:04:04]

On 2017/03/31 01:06:40, Michael Moss wrote:
> On 2017/03/31 01:02:57, Michael Moss wrote:
> > I believe this is causing compile failures on the official builders, e.g.:
> > 
> >
>
https://uberchromegw.corp.google.com/i/official.desktop/builders/win-pgo/buil...
> > 
> > src\third_party\webkit\source\bindings\core\v8\scriptwrappablevisitor.h(11):
> > fatal error C1083: Cannot open include file: 'platform/heap/VisitorImpl.h':
No
> > such file or directory
> 
> Looks like the failure was already noted in crbug.com/706985. Not sure why it
> hasn't been reverted yet.

Thanks, it merged without a problem back to M58 and I wasn't aware of any
refactoring happening between M57 and M58 in that area. Will investigate.

[Michael Lippautz, 2017-03-31 07:34:23]

Patchset #2 (id:20001) has been deleted