DescriptionRevert of Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController (patchset #4 id:60001 of https://codereview.chromium.org/2782413002/ )
Reason for revert:
This causes a crash in a telemetry benchmark on android. To reproduce, run:
src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse:media:youtube system_health.common_mobile
BUG=706865
Original issue's description:
> Get rid of computeVisibleSelectionInDOMTreeDeprecated() in InputMethodController::textInputType() and textInputInfo()
>
> This patch gets rid of |computeVisibleSelectionInDOMTreeDeprecated()| by replacing
> it with |rootEditableElementOf()| with non-canonicalize position from
> |textInputInfo()| and |textInputType()| of |InputMethodController| for improving
> code health.
>
> Node: Because of selection can't cross editing boundary, root editable element for
> non-canonicalized position and canonicalized position are same.
>
> This patch is intentionally not change all call sites of |rootEditableElement()|
> in |InputMethodController| to merge this patch as workaround of [1].
>
> [1] http://crbug.com/704763 Opacity animation consuming main thread resources
>
> BUG=698633, 704763
> TEST=n/a; no behavior changes
>
> Review-Url: https://codereview.chromium.org/2782413002
> Cr-Commit-Position: refs/heads/master@{#460705}
> Committed: https://chromium.googlesource.com/chromium/src/+/9744d5bffb3fbdf761455b355ebc4faa757d1aaf
TBR=tkent@chromium.org,xiaochengh@chromium.org,yoichio@chromium.org,yosin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=698633, 704763
Review-Url: https://codereview.chromium.org/2785333002
Cr-Commit-Position: refs/heads/master@{#460903}
Committed: https://chromium.googlesource.com/chromium/src/+/dc19a899c0f97dcd259a3ec506396c43db14ef23
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|