Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2785283003: Add set_autohide_systemui to wayland protocol (Closed)

Created:
3 years, 8 months ago by yorkelee
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Add set_autohide_systemui to wayland protocol * Bump multi-display wayland APIs to version 4. * Add set_autohide_systemui to version 3 of zcr_remote_shell_v1 BUG=705723 TEST=Verify that making the autohide request from Android results in the trace being logged. Unit tests will be added together with the actual implementation in the next CL. Review-Url: https://codereview.chromium.org/2777373002 Cr-Commit-Position: refs/heads/master@{#460383} (cherry picked from commit 23552624dd10da3c8add0d1e1ef3577898713a8c) Review-Url: https://codereview.chromium.org/2785283003 . Cr-Commit-Position: refs/branch-heads/3029@{#511} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7c28587f7bf7b2bf859d8514879b504f46660fa8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -27 lines) Patch
M components/exo/shell_surface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 4 chunks +10 lines, -2 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 7 chunks +48 lines, -7 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 7 chunks +44 lines, -6 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 3 chunks +8 lines, -7 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 6 chunks +23 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785283003/1
3 years, 8 months ago (2017-03-30 23:51:33 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-03-30 23:51:35 UTC) #4
oshima
3 years, 8 months ago (2017-03-31 11:38:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c28587f7bf7b2bf859d8514879b504f46660fa8.

Powered by Google App Engine
This is Rietveld 408576698