Description was changed from ========== Add ability to have active window autohide shelf * Bump ...
3 years, 9 months ago
(2017-03-27 22:58:32 UTC)
#1
Description was changed from
==========
Add ability to have active window autohide shelf
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.
==========
to
==========
Add ability to have active window autohide shelf
* Bump multi-display wayland APIs to version 4 since
they are not currently being used on Android.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.
==========
Split initial CL into two, these are the wayland/exo only changes. PTAL
3 years, 8 months ago
(2017-03-28 15:55:44 UTC)
#4
Split initial CL into two, these are the wayland/exo only changes. PTAL
yorkelee
Description was changed from ========== Add ability to have active window autohide shelf * Bump ...
3 years, 8 months ago
(2017-03-28 16:04:10 UTC)
#5
Description was changed from
==========
Add ability to have active window autohide shelf
* Bump multi-display wayland APIs to version 4 since
they are not currently being used on Android.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
* Add hide_shelf_when_active_ flag to window_state
which the ShelfLayoutManager uses to determine if
the currently active window should autohide the shelf.
BUG=705723
TEST=New unit tests, and also verify that using the
implementation from Android correctly autohides the shelf
for the active Android window.
==========
to
==========
Add set_autohide_systemui to wayland protocol
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
BUG: 705723
TEST: Verify that making the autohide request from Android
results in the trace being logged. Unit tests will be added
together with the actual implementation in the next CL.
==========
yorkelee
Description was changed from ========== Add set_autohide_systemui to wayland protocol * Bump multi-display wayland APIs ...
3 years, 8 months ago
(2017-03-28 16:05:05 UTC)
#6
Description was changed from
==========
Add set_autohide_systemui to wayland protocol
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
BUG: 705723
TEST: Verify that making the autohide request from Android
results in the trace being logged. Unit tests will be added
together with the actual implementation in the next CL.
==========
to
==========
Add set_autohide_systemui to wayland protocol
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
BUG=705723
TEST=Verify that making the autohide request from Android
results in the trace being logged. Unit tests will be added
together with the actual implementation in the next CL.
==========
reveman
lg in general, is there a bug or other documentation explaining why we need this ...
3 years, 8 months ago
(2017-03-28 16:17:03 UTC)
#7
https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml File third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml (right): https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml#newcode435 third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:435: Requests whether or not the surface will autohide the ...
3 years, 8 months ago
(2017-03-28 16:18:18 UTC)
#8
3 years, 8 months ago
(2017-03-28 16:23:59 UTC)
#9
https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):
https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:433:
<request name="set_autohide_systemui" since="3">
On 2017/03/28 16:17:03, reveman wrote:
> hm, adding a version 3 request and making current version 3 api version 4 will
> break existing clients. if client is not using version 3 api yet then why not
> just make this part of version 3? if version 3 is used then this new request
> must be version 4.
The client is not using version 3 api yet, and we are not landing the Android
side changes that use the multidisplay apis (that are currently version 3) in
m58.
I don't think there are any clients that are currently using version 3 right
now, Dominik, can you confirm?
yorkelee
Please see b/35874703 for the Android side bug that requires this feature https://codereview.chromium.org/2777373002/diff/20001/components/exo/shell_surface.cc File components/exo/shell_surface.cc ...
3 years, 8 months ago
(2017-03-28 17:33:25 UTC)
#10
>So we need the ability to have non-fullscreen windows that hide the shelf? >It's not ...
3 years, 8 months ago
(2017-03-28 18:06:59 UTC)
#13
>So we need the ability to have non-fullscreen windows that hide the shelf?
>It's
not enough for it to be hidden when entering fullscreen mode?
Yup, the intention here is to explicitly decouple the hiding of the shelf with
fullscreen mode.
This API is meant to be used by apps that hide the navigation bar on Android,
while fullscreen remains as something that is manually activated by the user.
https://codereview.chromium.org/2777373002/diff/40001/third_party/wayland-pro...
File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):
https://codereview.chromium.org/2777373002/diff/40001/third_party/wayland-pro...
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:189:
<enum name="shelf_autohide_state">
On 2017/03/28 17:58:12, reveman wrote:
> s/shelf/systemui/ ? I prefer the systemui term as it's less impl specific.
> Either way, we should be consistent.
Done.
https://codereview.chromium.org/2777373002/diff/80001/components/exo/shell_surface.h File components/exo/shell_surface.h (right): https://codereview.chromium.org/2777373002/diff/80001/components/exo/shell_surface.h#newcode136 components/exo/shell_surface.h:136: void SetAutohideShelf(uint32_t autohide); This should also be SetSystemUiVisibility as ...
3 years, 8 months ago
(2017-03-28 23:54:47 UTC)
#16
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started ...
3 years, 8 months ago
(2017-03-29 03:43:48 UTC)
#22
Dry run: Try jobs failed on following builders:
ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)
reveman
On 2017/03/28 at 18:07:32, domlaskowski wrote: > https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml > File third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml (right): > > https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml#newcode433 ...
3 years, 8 months ago
(2017-03-29 06:46:36 UTC)
#23
On 2017/03/28 at 18:07:32, domlaskowski wrote:
>
https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-pro...
> File
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml
(right):
>
>
https://codereview.chromium.org/2777373002/diff/20001/third_party/wayland-pro...
>
third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml:433:
<request name="set_autohide_systemui" since="3">
> On 2017/03/28 16:23:59, yorkelee wrote:
> > On 2017/03/28 16:17:03, reveman wrote:
> > > hm, adding a version 3 request and making current version 3 api version 4
will
> > > break existing clients. if client is not using version 3 api yet then why
not
> > > just make this part of version 3? if version 3 is used then this new
request
> > > must be version 4.
> >
> > The client is not using version 3 api yet, and we are not landing the
Android
> > side changes that use the multidisplay apis (that are currently version 3)
in
> > m58.
> >
> > I don't think there are any clients that are currently using version 3 right
> > now, Dominik, can you confirm?
>
> Right, we should bump multi-display to version 4 so it doesn't block this from
landing in M58.
>
Ah, thanks for explaining. That makes sense.
LGTM
yorkelee
The CQ bit was checked by yorkelee@google.com
3 years, 8 months ago
(2017-03-29 14:42:08 UTC)
#24
CQ is committing da patch. Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490798528160440, "parent_rev": "e7405101101410fd1ca1302ba7242a717d16aacb", "commit_rev": "23552624dd10da3c8add0d1e1ef3577898713a8c"}
3 years, 8 months ago
(2017-03-29 14:46:34 UTC)
#26
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490798528160440,
"parent_rev": "e7405101101410fd1ca1302ba7242a717d16aacb", "commit_rev":
"23552624dd10da3c8add0d1e1ef3577898713a8c"}
commit-bot: I haz the power
Description was changed from ========== Add set_autohide_systemui to wayland protocol * Bump multi-display wayland APIs ...
3 years, 8 months ago
(2017-03-29 14:47:15 UTC)
#27
Message was sent while issue was closed.
Description was changed from
==========
Add set_autohide_systemui to wayland protocol
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
BUG=705723
TEST=Verify that making the autohide request from Android
results in the trace being logged. Unit tests will be added
together with the actual implementation in the next CL.
==========
to
==========
Add set_autohide_systemui to wayland protocol
* Bump multi-display wayland APIs to version 4.
* Add set_autohide_systemui to version 3 of
zcr_remote_shell_v1
BUG=705723
TEST=Verify that making the autohide request from Android
results in the trace being logged. Unit tests will be added
together with the actual implementation in the next CL.
Review-Url: https://codereview.chromium.org/2777373002
Cr-Commit-Position: refs/heads/master@{#460383}
Committed:
https://chromium.googlesource.com/chromium/src/+/23552624dd10da3c8add0d1e1ef3...
==========
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/23552624dd10da3c8add0d1e1ef3577898713a8c
3 years, 8 months ago
(2017-03-29 14:47:16 UTC)
#28
Issue 2777373002: Add set_autohide_systemui to wayland protocol
(Closed)
Created 3 years, 9 months ago by yorkelee
Modified 3 years, 8 months ago
Reviewers: reveman, Dominik Laskowski, oshima, Mr4D (OOO till 08-26)
Base URL:
Comments: 27
Chromium Code Reviews
Issue
2777373002:
Add set_autohide_systemui to wayland protocol (Closed)
