Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2785243002:
[Chromecast] Fix Cast Audio Linux bot swarming settings. (Closed)
|
Created:
3 years, 8 months ago by mbjorge Modified:
3 years, 8 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Chromecast] Fix Cast Audio Linux bot swarming settings.
content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing.
Also remove ppapi unittests to match Cast Linux config; they should not have been added in the first place.
BUG=706555, 684527
Review-Url: https://codereview.chromium.org/2785243002
Cr-Commit-Position: refs/heads/master@{#460902}
Committed: https://chromium.googlesource.com/chromium/src/+/6ec5a4e0e68acaa55f3363ceec7523c990c0bba5
Patch Set 1 #Patch Set 2 : Only disable content_browsertests on swarming #
Total comments: 1
Messages
Total messages: 19 (6 generated)
mbjorge@chromium.org changed reviewers: + dpranke@chromium.org
*None* of these tests work under swarming? We need to fix things so that they all do ...
On 2017/03/30 at 18:07:12, dpranke wrote: > *None* of these tests work under swarming? > > We need to fix things so that they all do ... Ah, no I think most do. From a recent run, everything is green except for content_browsertests and cast_shell_browsertests: https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/bui... content_browsertests if failing because it can't find the buildbot/filter/cast-linux.content_browsertests.filter file. cast_shell_browsertests I think should be fixed by my other CL (https://codereview.chromium.org/2777413007). Should I just change content_browsertests to false and leave the others true? Should I update the Cast Linux config too?
On 2017/03/30 at 18:18:50, mbjorge wrote: > On 2017/03/30 at 18:07:12, dpranke wrote: > > *None* of these tests work under swarming? > > > > We need to fix things so that they all do ... > > Ah, no I think most do. From a recent run, everything is green except for content_browsertests and cast_shell_browsertests: https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/bui... > > content_browsertests if failing because it can't find the buildbot/filter/cast-linux.content_browsertests.filter file. > cast_shell_browsertests I think should be fixed by my other CL (https://codereview.chromium.org/2777413007). > > Should I just change content_browsertests to false and leave the others true? Should I update the Cast Linux config too? I was just updating this to match the Cast Linux config
On 2017/03/30 18:19:19, mbjorge wrote: > On 2017/03/30 at 18:18:50, mbjorge wrote: > > On 2017/03/30 at 18:07:12, dpranke wrote: > > > *None* of these tests work under swarming? > > > > > > We need to fix things so that they all do ... > > > > Ah, no I think most do. From a recent run, everything is green except for > content_browsertests and cast_shell_browsertests: > https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/bui... > > > > content_browsertests if failing because it can't find the > buildbot/filter/cast-linux.content_browsertests.filter file. > > cast_shell_browsertests I think should be fixed by my other CL > (https://codereview.chromium.org/2777413007). > > > > Should I just change content_browsertests to false and leave the others true? > Should I update the Cast Linux config too? > > I was just updating this to match the Cast Linux config Please leave as many things running under swarming as you can, and we need to fix the things that can't. Usually getting things to work under swarming is pretty easy to do, particularly if you have a tryserver to test against. Did we not set up a cast audio trybot? I thought we did.
On 2017/03/30 at 18:22:28, dpranke wrote: > On 2017/03/30 18:19:19, mbjorge wrote: > > On 2017/03/30 at 18:18:50, mbjorge wrote: > > > On 2017/03/30 at 18:07:12, dpranke wrote: > > > > *None* of these tests work under swarming? > > > > > > > > We need to fix things so that they all do ... > > > > > > Ah, no I think most do. From a recent run, everything is green except for > > content_browsertests and cast_shell_browsertests: > > https://build.chromium.org/p/chromium.linux/builders/Cast%20Audio%20Linux/bui... > > > > > > content_browsertests if failing because it can't find the > > buildbot/filter/cast-linux.content_browsertests.filter file. > > > cast_shell_browsertests I think should be fixed by my other CL > > (https://codereview.chromium.org/2777413007). > > > > > > Should I just change content_browsertests to false and leave the others true? > > Should I update the Cast Linux config too? > > > > I was just updating this to match the Cast Linux config > > Please leave as many things running under swarming as you can, and we need to fix the things that can't. > > Usually getting things to work under swarming is pretty easy to do, particularly if you have a tryserver to test against. > > Did we not set up a cast audio trybot? I thought we did. kk, will update to just change content_browsertests. We setup the cast_shell_audio_linux bot on tryserver.chromium.linux: https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_aud...
Description was changed from ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. Match the can_use_on_swarming_builders setting used for Cast Linux bot. The CL that created the Cast Audio Linux bot was created before the Cast Linux settings got updated (crbug/684527), so it got out of sync. BUG=706555, 684527 ========== to ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing. BUG=706555, 684527 ==========
On 2017/03/30 18:33:28, mbjorge wrote: > We setup the cast_shell_audio_linux bot on tryserver.chromium.linux: > https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_aud... Hm. And yet I don't see it in the "choose trybots" list. Can you file a trooper bug to get someone to look into that?
https://codereview.chromium.org/2785243002/diff/20001/testing/buildbot/chromi... File testing/buildbot/chromium.linux.json (left): https://codereview.chromium.org/2785243002/diff/20001/testing/buildbot/chromi... testing/buildbot/chromium.linux.json:2620: "test": "ppapi_unittests" Is this change intentional?
Description was changed from ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing. BUG=706555, 684527 ========== to ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing. Also remove ppapi unittests to match Cast Linux config; they should not have been added in the first place. BUG=706555, 684527 ==========
On 2017/03/30 at 18:50:19, dpranke wrote: > On 2017/03/30 18:33:28, mbjorge wrote: > > We setup the cast_shell_audio_linux bot on tryserver.chromium.linux: > > https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_aud... > > Hm. And yet I don't see it in the "choose trybots" list. Can you file a trooper bug to get someone to look into that? Kk, filed via go/bugatrooper https://bugs.chromium.org/p/chromium/issues/detail?id=706980
On 2017/03/30 at 18:50:24, dpranke wrote: > https://codereview.chromium.org/2785243002/diff/20001/testing/buildbot/chromi... > File testing/buildbot/chromium.linux.json (left): > > https://codereview.chromium.org/2785243002/diff/20001/testing/buildbot/chromi... > testing/buildbot/chromium.linux.json:2620: "test": "ppapi_unittests" > Is this change intentional? Yeah, it was out of date. This got removed from the Cast Linux build after I uploaded the initial CL, so this just to match Cast Linux config better since we don't use this anymore (https://codereview.chromium.org/2649353007). Updated the commit message to make it clear it's intentional.
lgtm
The CQ bit was checked by mbjorge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490905872030950,
"parent_rev": "66e35d23b968c06da931647b9087362840434f64", "commit_rev":
"6ec5a4e0e68acaa55f3363ceec7523c990c0bba5"}
Message was sent while issue was closed.
Description was changed from ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing. Also remove ppapi unittests to match Cast Linux config; they should not have been added in the first place. BUG=706555, 684527 ========== to ========== [Chromecast] Fix Cast Audio Linux bot swarming settings. content_browsertests fails on swarming. Don't run on swarming to match the configuration of the Cast Linux bot, where content_browsertests is passing. Also remove ppapi unittests to match Cast Linux config; they should not have been added in the first place. BUG=706555, 684527 Review-Url: https://codereview.chromium.org/2785243002 Cr-Commit-Position: refs/heads/master@{#460902} Committed: https://chromium.googlesource.com/chromium/src/+/6ec5a4e0e68acaa55f3363ceec75... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6ec5a4e0e68acaa55f3363ceec75... |
