|
|
Chromium Code Reviews
Description[chromecast] Removes pepper plugin support.
BUG=666790
Review-Url: https://codereview.chromium.org/2649353007
Cr-Commit-Position: refs/heads/master@{#446538}
Committed: https://chromium.googlesource.com/chromium/src/+/827b0c2d5be45551cf28747392ea269553820900
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : fixes gncheck #Patch Set 4 : rebase #
Messages
Total messages: 28 (18 generated)
The CQ bit was checked by alokp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
alokp@chromium.org changed reviewers: + jam@chromium.org, mbjorge@chromium.org
jam: ppapi/ and testing/ mbjorge: chromecast/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by alokp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chromecast/ lgtm, in the sense that the change looks fine. I have no idea if we are actually using pepper, though. jc, did you do a before/after and see if this did improve compile times / output size?
On 2017/01/24 22:52:24, mbjorge wrote: > chromecast/ lgtm, in the sense that the change looks fine. I have no idea if we > are actually using pepper, though. We added the support about 2 years ago for a cast application: https://chromium.googlesource.com/chromium/src/+/ed6fdc5f9d86c8a53b075b33105e... That particular application has been re-implemented to use pure HTML5 API. It does not need pepper plugins anymore. Hence this patch. > jc, did you do a before/after and see if this did improve compile times / output > size? Not this time, but when we added it, there was a binary size bump of ~1M.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
lgtm
The CQ bit was checked by alokp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by alokp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org, mbjorge@chromium.org Link to the patchset: https://codereview.chromium.org/2649353007/#ps40001 (title: "fixes gncheck")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by alokp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org, mbjorge@chromium.org Link to the patchset: https://codereview.chromium.org/2649353007/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485475176046800,
"parent_rev": "dabf9720a3d0b183c8a921da5cbf9c079322882b", "commit_rev":
"827b0c2d5be45551cf28747392ea269553820900"}
Message was sent while issue was closed.
Description was changed from ========== [chromecast] Removes pepper plugin support. BUG=666790 ========== to ========== [chromecast] Removes pepper plugin support. BUG=666790 Review-Url: https://codereview.chromium.org/2649353007 Cr-Commit-Position: refs/heads/master@{#446538} Committed: https://chromium.googlesource.com/chromium/src/+/827b0c2d5be45551cf28747392ea... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/827b0c2d5be45551cf28747392ea... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
