Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2649353007: [chromecast] Removes pepper plugin support. (Closed)

Created:
3 years, 11 months ago by alokp
Modified:
3 years, 11 months ago
Reviewers:
jam, mbjorge
CC:
alokp+watch_chromium.org, chromium-reviews, halliwell+watch_chromium.org, lcwu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Removes pepper plugin support. BUG=666790 Review-Url: https://codereview.chromium.org/2649353007 Cr-Commit-Position: refs/heads/master@{#446538} Committed: https://chromium.googlesource.com/chromium/src/+/827b0c2d5be45551cf28747392ea269553820900

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fixes gncheck #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chromecast/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/features/features.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (18 generated)
alokp
jam: ppapi/ and testing/ mbjorge: chromecast/
3 years, 11 months ago (2017-01-24 22:17:31 UTC) #4
mbjorge
chromecast/ lgtm, in the sense that the change looks fine. I have no idea if ...
3 years, 11 months ago (2017-01-24 22:52:24 UTC) #9
alokp
On 2017/01/24 22:52:24, mbjorge wrote: > chromecast/ lgtm, in the sense that the change looks ...
3 years, 11 months ago (2017-01-24 23:03:06 UTC) #10
jam
lgtm
3 years, 11 months ago (2017-01-25 00:09:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649353007/20001
3 years, 11 months ago (2017-01-26 01:03:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/298460)
3 years, 11 months ago (2017-01-26 01:24:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649353007/40001
3 years, 11 months ago (2017-01-26 07:17:46 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/298618)
3 years, 11 months ago (2017-01-26 07:41:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2649353007/60001
3 years, 11 months ago (2017-01-27 00:01:08 UTC) #25
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 02:18:53 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/827b0c2d5be45551cf28747392ea...

Powered by Google App Engine
This is Rietveld 408576698