Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2785213002: Remove unused variable layout_object. (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused variable layout_object. clang triggered compilation errors about this unused variable when experimenting with a unity build. Not sure why doesn't detect that it is unused normally. R=mstensho@opera.com Review-Url: https://codereview.chromium.org/2785213002 Cr-Commit-Position: refs/heads/master@{#460862} Committed: https://chromium.googlesource.com/chromium/src/+/d26bf4eee20da2e4facbbf1767b05627a6808484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_layout_result.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Daniel Bratell
3 years, 8 months ago (2017-03-30 16:20:46 UTC) #1
cbiesinger
lgtm
3 years, 8 months ago (2017-03-30 16:29:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2785213002/1
3 years, 8 months ago (2017-03-30 17:26:41 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 20:29:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d26bf4eee20da2e4facbbf1767b0...

Powered by Google App Engine
This is Rietveld 408576698