Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2784603003: Revert of [inspector] console get all information from inspector when needed (Closed)

Created:
3 years, 8 months ago by Michael Achenbach
Modified:
3 years, 8 months ago
Reviewers:
kozy, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] console get all information from inspector when needed (patchset #4 id:60001 of https://codereview.chromium.org/2784713002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/14569 Original issue's description: > [inspector] console get all information from inspector when needed > > With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data. > It allows us to implement console methods without taking in account how and where we create and store these methods: > - later we can move console object implementation to builtins.. > - ..and install command line API methods smarter. > > BUG=chromium:588893 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2784713002 > Cr-Commit-Position: refs/heads/master@{#44212} > Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:588893 Review-Url: https://codereview.chromium.org/2784603003 Cr-Commit-Position: refs/heads/master@{#44217} Committed: https://chromium.googlesource.com/v8/v8/+/f11719ce793ad3c664127a379413c0c3cffc5685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -968 lines) Patch
M src/inspector/inspected-context.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/inspected-context.cc View 2 chunks +28 lines, -2 lines 0 comments Download
M src/inspector/v8-console.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/v8-console.cc View 17 chunks +232 lines, -121 lines 0 comments Download
M src/inspector/v8-console-message.h View 3 chunks +2 lines, -17 lines 0 comments Download
M src/inspector/v8-console-message.cc View 5 chunks +11 lines, -39 lines 0 comments Download
M test/inspector/protocol-test.js View 1 chunk +0 lines, -2 lines 0 comments Download
D test/inspector/runtime/command-line-api.js View 1 chunk +0 lines, -175 lines 0 comments Download
D test/inspector/runtime/command-line-api-expected.txt View 1 chunk +0 lines, -612 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [inspector] console get all information from inspector when needed
3 years, 8 months ago (2017-03-29 07:37:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784603003/1
3 years, 8 months ago (2017-03-29 07:37:27 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 07:37:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f11719ce793ad3c664127a379413c0c3cff...

Powered by Google App Engine
This is Rietveld 408576698