[inspector] console get all information from inspector when needed

[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of JavaScript console object and able to get all required information from callback data.
It allows us to implement console methods without taking in account how and where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Original-Commit-Position: refs/heads/master@{#44212}
Committed: https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca915f4c
Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44238}
Committed: https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8ea2e79
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44251}
Committed: https://chromium.googlesource.com/v8/v8/+/3ab262774a2825879c0363c4681510ec7b62c6e5

[kozy, 2017-03-28 22:33:43]

Dmitry, please take a look.

[kozy, 2017-03-28 23:28:56]

Dmitry, please take another look.

[dgozman, 2017-03-28 23:53:57]

Nice patch! lgtm

https://codereview.chromium.org/2784713002/diff/20001/src/inspector/v8-consol...
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2784713002/diff/20001/src/inspector/v8-consol...
src/inspector/v8-console.cc:81:
m_inspector->ensureConsoleMessageStorage(m_groupId)->addMessage(
consoleMessageStorage()->addMessage(...)

[kozy, 2017-03-28 23:57:39]

thanks!
all done.

https://codereview.chromium.org/2784713002/diff/20001/src/inspector/v8-consol...
File src/inspector/v8-console.cc (right):

https://codereview.chromium.org/2784713002/diff/20001/src/inspector/v8-consol...
src/inspector/v8-console.cc:81:
m_inspector->ensureConsoleMessageStorage(m_groupId)->addMessage(
On 2017/03/28 23:53:57, dgozman wrote:
> consoleMessageStorage()->addMessage(...)

Done.

[kozy, 2017-03-28 23:57:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-28 23:57:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784713002/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-03-28 23:57:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 00:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 00:24:30]

Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[kozy, 2017-03-29 00:52:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-29 00:52:13]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784713002/#ps60001
(title: "better test")

[commit-bot: I haz the power, 2017-03-29 00:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 01:25:52]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490748733010060,
"parent_rev": "4e3f4b2d121dc9c77a880b16f82a1af277a23a27", "commit_rev":
"908cd38123df33ce293e4c8d25e407f7ca915f4c"}

[commit-bot: I haz the power, 2017-03-29 01:25:57]

Description was changed from

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org
==========

to

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
==========

[commit-bot: I haz the power, 2017-03-29 01:25:58]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...

[Michael Achenbach, 2017-03-29 07:37:13]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2784603003/ by machenbach@chromium.org.

The reason for reverting is: Breaks layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[kozy, 2017-03-29 15:21:26]

Description was changed from

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
==========

to

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
==========

[kozy, 2017-03-29 15:23:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-29 15:23:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784713002/#ps80001
(title: "more tests, fixed memory")

[kozy, 2017-03-29 15:23:49]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2017-03-29 15:23:53]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 15:50:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490801033313150,
"parent_rev": "dbb1cbe3a85d5c5528ce876d905e78d2ab35f00b", "commit_rev":
"88f71126a5c067f98c75044bc26778f2e8ea2e79"}

[commit-bot: I haz the power, 2017-03-29 15:50:09]

Description was changed from

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
==========

to

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44238}
Committed:
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...
==========

[commit-bot: I haz the power, 2017-03-29 15:50:10]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...

[kozy, 2017-03-29 19:42:34]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2778743007/ by kozyatinskiy@chromium.org.

The reason for reverting is: One more failed layout test..

[kozy, 2017-03-29 19:54:31]

Description was changed from

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44238}
Committed:
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...
==========

to

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44238}
Committed:
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...
==========

[kozy, 2017-03-29 20:27:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-03-29 20:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2784713002/#ps100001
(title: "fixed last test")

[commit-bot: I haz the power, 2017-03-29 20:27:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 21:40:08]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490819251339330,
"parent_rev": "f2531acb1e7ea7c0e1bde2f8230c6b49539dd429", "commit_rev":
"3ab262774a2825879c0363c4681510ec7b62c6e5"}

[commit-bot: I haz the power, 2017-03-29 21:40:13]

Description was changed from

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44238}
Committed:
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...
==========

to

==========
[inspector] console get all information from inspector when needed

With this CL we don't need to store reference to InspectedContext inside of
JavaScript console object and able to get all required information from callback
data.
It allows us to implement console methods without taking in account how and
where we create and store these methods:
- later we can move console object implementation to builtins..
- ..and install command line API methods smarter.

BUG=chromium:588893
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Original-Commit-Position: refs/heads/master@{#44212}
Committed:
https://chromium.googlesource.com/v8/v8/+/908cd38123df33ce293e4c8d25e407f7ca9...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Original-Commit-Position: refs/heads/master@{#44238}
Committed:
https://chromium.googlesource.com/v8/v8/+/88f71126a5c067f98c75044bc26778f2e8e...
Review-Url: https://codereview.chromium.org/2784713002
Cr-Commit-Position: refs/heads/master@{#44251}
Committed:
https://chromium.googlesource.com/v8/v8/+/3ab262774a2825879c0363c4681510ec7b6...
==========

[commit-bot: I haz the power, 2017-03-29 21:40:14]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/3ab262774a2825879c0363c4681510ec7b6...