Move PrefRegistrySimple to use unique_ptr<Value>

Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2784513002
Cr-Commit-Position: refs/heads/master@{#460366}
Committed: https://chromium.googlesource.com/chromium/src/+/88e50721bcd19d719d3417ac9c3f86dd87439268

[vabr (Chromium), 2017-03-28 15:33:36]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 15:34:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-28 15:45:45]

Description was changed from

==========
Move TestingPrefService to use unique_ptr<Value>

Various Set*Pref methods of TestingPrefService pass Value ownership with a raw
pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

to

==========
Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass
Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

[commit-bot: I haz the power, 2017-03-28 15:50:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 15:50:31]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[vabr (Chromium), 2017-03-28 16:08:33]

Description was changed from

==========
Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass
Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
==========

to

==========
Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass
Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[vabr (Chromium), 2017-03-28 16:08:40]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 16:09:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-03-28 16:52:18]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org, jdoerrie@chromium.org, jochen@chromium.org

[vabr (Chromium), 2017-03-28 16:52:19]

Hi all,
Similarly to the previous CL:

bauerb@, please review components/prefs/pref_registry_simple.*, which is the key
change.

jdoerrie@, please spot check the rest of the CL. It is again all just mechanical
changes.

jochen@, please rubber-stamp //chrome/browser and //components.

I will wait for the review from bauerb@ and jdoerrie@ and will TBR jochen@ if
needed.

Thanks all!

Vaclav

[commit-bot: I haz the power, 2017-03-28 17:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 17:14:12]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-03-29 06:27:40]

rubberstamp lgtm

[jdoerrie, 2017-03-29 09:16:20]

On 2017/03/29 06:27:40, jochen wrote:
> rubberstamp lgtm

Spot checked, LGTM!

[Bernhard Bauer, 2017-03-29 09:23:28]

lgtm

[vabr (Chromium), 2017-03-29 13:16:23]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-03-29 13:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-29 13:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490793383347130,
"parent_rev": "3d95ca9fd487e0a0dd2617eee0f683eea7a7bed0", "commit_rev":
"88e50721bcd19d719d3417ac9c3f86dd87439268"}

[commit-bot: I haz the power, 2017-03-29 13:23:13]

Description was changed from

==========
Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass
Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Move PrefRegistrySimple to use unique_ptr<Value>

RegisterListPref and RegisterDictionaryPref methods of PrefRegistrySimple pass
Value ownership with a raw pointer.

This CL changes that to passing unique_ptr, because that is a safer and clearer
option. It is also a pre-requisite for migrating Value API off raw pointer
ownership passing.

BUG=697817
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2784513002
Cr-Commit-Position: refs/heads/master@{#460366}
Committed:
https://chromium.googlesource.com/chromium/src/+/88e50721bcd19d719d3417ac9c3f...
==========

[commit-bot: I haz the power, 2017-03-29 13:23:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88e50721bcd19d719d3417ac9c3f...