Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2784463002: Revert of chrome/android: Push EventFilters into the Layout implementations. (Closed)

Created:
3 years, 8 months ago by Matt Giuca
Modified:
3 years, 8 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of chrome/android: Push EventFilters into the Layout implementations. (patchset #5 id:80001 of https://codereview.chromium.org/2774443002/ ) Reason for revert: Made Android tabstrip completely unresponsive to touch. BUG=705841 Original issue's description: > chrome/android: Push EventFilters into the Layout implementations. > > EventFilters are currently built by the LayoutManager and all gestures > are routed through it to the active layout. This indirection is > unnecessary since only the StackLayout requires gesture handling. This > also ends up exposing public APIs on the Layouts making it difficult to > follow the path for events from different sources (CompositorView vs > the Toolbar). > > This change pushes EventFilters deeper into the Layout implementations, > so the Layouts directly consume touch events and generate gestures if > necessary. Layout still has an API for swipe gestures coming from the > toolbar. > > BUG= > > Review-Url: https://codereview.chromium.org/2774443002 > Cr-Commit-Position: refs/heads/master@{#459980} > Committed: https://chromium.googlesource.com/chromium/src/+/ef25f0df9d626028752de7d945d89abe15d39dfb TBR=dtrainor@chromium.org,mdjones@chromium.org,khushalsagar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2784463002 Cr-Commit-Position: refs/heads/master@{#460022} Committed: https://chromium.googlesource.com/chromium/src/+/6cbf12a1814e63a869a21890199f3a7babf51867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -293 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/GestureHandlerLayoutDelegate.java View 1 chunk +65 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/Layout.java View 6 chunks +86 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java View 5 chunks +22 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromeTablet.java View 4 chunks +66 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java View 4 chunks +3 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java View 10 chunks +90 lines, -148 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManager.java View 5 chunks +92 lines, -79 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java View 3 chunks +3 lines, -11 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/TabStripUtils.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Matt Giuca
Created Revert of chrome/android: Push EventFilters into the Layout implementations.
3 years, 8 months ago (2017-03-28 05:53:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784463002/1
3 years, 8 months ago (2017-03-28 05:53:24 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 05:55:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6cbf12a1814e63a869a21890199f...

Powered by Google App Engine
This is Rietveld 408576698