Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2603)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java

Issue 2784463002: Revert of chrome/android: Push EventFilters into the Layout implementations. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java
index 4d19153015843b4517bdb345deff02118c0fd098..514721a1644758ab04d7d08ede3f64b5264e51c6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/SimpleAnimationLayout.java
@@ -15,7 +15,6 @@
import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;
import org.chromium.chrome.browser.compositor.layouts.components.LayoutTab;
import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
-import org.chromium.chrome.browser.compositor.layouts.eventfilter.BlackHoleEventFilter;
import org.chromium.chrome.browser.compositor.layouts.eventfilter.EventFilter;
import org.chromium.chrome.browser.compositor.layouts.phone.stack.Stack;
import org.chromium.chrome.browser.compositor.layouts.phone.stack.StackAnimation;
@@ -67,7 +66,6 @@
private LayoutTab mAnimatedTab;
private final TabListSceneLayer mSceneLayer;
- private final BlackHoleEventFilter mBlackHoleEventFilter;
/**
* Creates an instance of the {@link SimpleAnimationLayout}.
@@ -76,10 +74,9 @@
* @param renderHost The {@link LayoutRenderHost} view for this layout.
* @param eventFilter The {@link EventFilter} that is needed for this view.
*/
- public SimpleAnimationLayout(
- Context context, LayoutUpdateHost updateHost, LayoutRenderHost renderHost) {
- super(context, updateHost, renderHost);
- mBlackHoleEventFilter = new BlackHoleEventFilter(context);
+ public SimpleAnimationLayout(Context context, LayoutUpdateHost updateHost,
+ LayoutRenderHost renderHost, EventFilter eventFilter) {
+ super(context, updateHost, renderHost, eventFilter);
mSceneLayer = new TabListSceneLayer();
}
@@ -410,11 +407,6 @@
public void onPropertyAnimationFinished(Property prop) {}
@Override
- protected EventFilter getEventFilter() {
- return mBlackHoleEventFilter;
- }
-
- @Override
protected SceneLayer getSceneLayer() {
return mSceneLayer;
}

Powered by Google App Engine
This is Rietveld 408576698