Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1772)

Unified Diff: chromecast/media/audio/cast_audio_manager.h

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)
Patch Set: fixes content_browsertests and content_unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/audio/cast_audio_manager.h
diff --git a/chromecast/media/audio/cast_audio_manager.h b/chromecast/media/audio/cast_audio_manager.h
index 677954eac15303e111e3e871a42ac61c3c78432c..428e845cf438708b8fad989ce381f8b19286f051 100644
--- a/chromecast/media/audio/cast_audio_manager.h
+++ b/chromecast/media/audio/cast_audio_manager.h
@@ -30,6 +30,7 @@ class CastAudioManager : public ::media::AudioManagerBase {
::media::AudioLogFactory* audio_log_factory,
MediaPipelineBackendManager* backend_manager,
CastAudioMixer* audio_mixer);
+ ~CastAudioManager() override;
// AudioManager implementation.
bool HasAudioOutputDevices() override;
@@ -48,9 +49,6 @@ class CastAudioManager : public ::media::AudioManagerBase {
virtual std::unique_ptr<MediaPipelineBackend> CreateMediaPipelineBackend(
const MediaPipelineDeviceParams& params);
- protected:
- ~CastAudioManager() override;
-
private:
// AudioManagerBase implementation.
::media::AudioOutputStream* MakeLinearOutputStream(

Powered by Google App Engine
This is Rietveld 408576698