Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6964)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 2784433002: Ensures that audio tasks cannot run after AudioManager is deleted. (Closed)
Patch Set: fixes content_browsertests and content_unittests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index c7e9033b501bec54fb8b4b6ea231ffec28c0342c..c90a40cf8b2d6e51b8492e6c91db2e3e255ce722 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -191,11 +191,14 @@ CastContentBrowserClient::media_pipeline_backend_manager() {
return cast_browser_main_parts_->media_pipeline_backend_manager();
}
-::media::ScopedAudioManagerPtr CastContentBrowserClient::CreateAudioManager(
+std::unique_ptr<::media::AudioManager>
+CastContentBrowserClient::CreateAudioManager(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
::media::AudioLogFactory* audio_log_factory) {
- return ::media::ScopedAudioManagerPtr(new media::CastAudioManager(
- GetMediaTaskRunner(), GetMediaTaskRunner(), audio_log_factory,
- media_pipeline_backend_manager()));
+ return base::MakeUnique<media::CastAudioManager>(
+ task_runner, worker_task_runner, audio_log_factory,
+ media_pipeline_backend_manager());
}
std::unique_ptr<::media::CdmFactory>

Powered by Google App Engine
This is Rietveld 408576698