Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2784423003: clang: Stop implicitly passing -Wl,--build-id to the linker. (Closed)

Created:
3 years, 8 months ago by Nico
Modified:
3 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

clang: Stop implicitly passing -Wl,--build-id to the linker. We explicitly pass that in official builds now, and after we've built and rolled in a compiler with this change here, we'll no longer ask the linker to generate a build id in unofficial builds (where it's not needed), which should speed up links a bit. BUG=622775 Review-Url: https://codereview.chromium.org/2784423003 Cr-Commit-Position: refs/heads/master@{#462898} Committed: https://chromium.googlesource.com/chromium/src/+/d2b7120358af144734c354fb2f9679c2d5647b35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nico
3 years, 8 months ago (2017-03-31 19:54:09 UTC) #3
hans
lgtm
3 years, 8 months ago (2017-04-07 15:52:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784423003/1
3 years, 8 months ago (2017-04-07 15:55:59 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 17:05:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d2b7120358af144734c354fb2f96...

Powered by Google App Engine
This is Rietveld 408576698