tools/clang/scripts/update.py - Issue 2784423003: clang: Stop implicitly passing -Wl,--build-id to the linker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/scripts/update.py

Issue 2784423003: clang: Stop implicitly passing -Wl,--build-id to the linker. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/scripts/update.py

diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py

index 2ea0d6d3d21b8651672061f4e6df6abc2cd3ae42..44fc0d93e6843fdaa009c81be6285de1b5e88f0b 100755

--- a/tools/clang/scripts/update.py

+++ b/tools/clang/scripts/update.py

@@ -647,9 +647,6 @@ def UpdateClang(args):

'-DCMAKE_SHARED_LINKER_FLAGS=' + ' '.join(ldflags),

'-DCMAKE_MODULE_LINKER_FLAGS=' + ' '.join(ldflags),

'-DCMAKE_INSTALL_PREFIX=' + LLVM_BUILD_DIR,

- # TODO(thakis): Remove this once official builds pass -Wl,--build-id

- # explicitly, https://crbug.com/622775

- '-DENABLE_LINKER_BUILD_ID=ON',

'-DCHROMIUM_TOOLS_SRC=%s' % os.path.join(CHROMIUM_DIR, 'tools', 'clang'),

'-DCHROMIUM_TOOLS=%s' % ';'.join(chrome_tools)]

« no previous file with comments | « no previous file | no next file » | no next file with comments »