Changes how window is updated when display changes in mash

Changes how window is updated when display changes in mash

Ash relies on the display being updated, then the WindowTreeHost's
window, and finally observers.

BUG=698914
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2784173002
Cr-Commit-Position: refs/heads/master@{#460888}
Committed: https://chromium.googlesource.com/chromium/src/+/8acdab00b16788a8525c8dc5437a8b43d651892a

[sky, 2017-03-30 04:26:30]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 04:26:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 05:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 05:36:28]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[James Cook, 2017-03-30 15:34:35]

LGTM

https://codereview.chromium.org/2784173002/diff/20001/ash/mus/window_manager.cc
File ash/mus/window_manager.cc (right):

https://codereview.chromium.org/2784173002/diff/20001/ash/mus/window_manager....
ash/mus/window_manager.cc:507: }
optional: line wrapping in this function might be better with "using
display::DisplayList" and/or putting screen_->display_list() in a local.

[sky, 2017-03-30 19:04:18]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-30 19:04:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2784173002/#ps40001
(title: "feedback")

[sky, 2017-03-30 19:04:24]

https://codereview.chromium.org/2784173002/diff/20001/ash/mus/window_manager.cc
File ash/mus/window_manager.cc (right):

https://codereview.chromium.org/2784173002/diff/20001/ash/mus/window_manager....
ash/mus/window_manager.cc:507: }
On 2017/03/30 15:34:34, James Cook wrote:
> optional: line wrapping in this function might be better with "using
> display::DisplayList" and/or putting screen_->display_list() in a local.

I went with making a local for screen_->display_list().

[commit-bot: I haz the power, 2017-03-30 19:05:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-30 19:07:28]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-30 19:07:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2784173002/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2017-03-30 19:08:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 21:37:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490900848281490,
"parent_rev": "b62c0d449adee39905c8e0b7cd262f22502ae67a", "commit_rev":
"8acdab00b16788a8525c8dc5437a8b43d651892a"}

[commit-bot: I haz the power, 2017-03-30 21:37:59]

Description was changed from

==========
Changes how window is updated when display changes in mash

Ash relies on the display being updated, then the WindowTreeHost's
window, and finally observers.

BUG=698914
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Changes how window is updated when display changes in mash

Ash relies on the display being updated, then the WindowTreeHost's
window, and finally observers.

BUG=698914
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2784173002
Cr-Commit-Position: refs/heads/master@{#460888}
Committed:
https://chromium.googlesource.com/chromium/src/+/8acdab00b16788a8525c8dc5437a...
==========

[commit-bot: I haz the power, 2017-03-30 21:38:00]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8acdab00b16788a8525c8dc5437a...