Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2784073002: Milo: Fix naming of pubsub settings (Closed)

Created:
3 years, 8 months ago by Ryan Tseng
Modified:
3 years, 8 months ago
Reviewers:
nodir, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Fix naming of pubsub settings This should've been "subscription" not "topic" BUG= Review-Url: https://codereview.chromium.org/2784073002 Committed: https://github.com/luci/luci-go/commit/530908a6c3d10f70895d64aceae79aef0cb9b50d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M milo/appengine/buildbot/build_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M milo/appengine/buildbot/pubsub.go View 1 chunk +4 lines, -4 lines 0 comments Download
M milo/common/config/settings.proto View 1 chunk +4 lines, -4 lines 0 comments Download
M milo/common/config/settings.pb.go View 4 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
hinoka
ptal
3 years, 8 months ago (2017-03-29 22:42:39 UTC) #4
nodir
just renaming the fields in the config file after uploading this version should work lgtm
3 years, 8 months ago (2017-03-29 22:45:04 UTC) #5
hinoka
I haven't set the luci-config version to default yet, so that should make things a ...
3 years, 8 months ago (2017-03-29 22:47:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784073002/1
3 years, 8 months ago (2017-03-29 22:47:53 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 22:53:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/530908a6c3d10f70895d64aceae79aef0cb9b50d

Powered by Google App Engine
This is Rietveld 408576698