Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: milo/appengine/buildbot/pubsub.go

Issue 2784073002: Milo: Fix naming of pubsub settings (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/build_test.go ('k') | milo/common/config/settings.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/pubsub.go
diff --git a/milo/appengine/buildbot/pubsub.go b/milo/appengine/buildbot/pubsub.go
index 52c0e6ea07a560da2b8ea6dbd8232fa41e44d54f..db8136fcf05ed27cb3a44521132d272cce719a0a 100644
--- a/milo/appengine/buildbot/pubsub.go
+++ b/milo/appengine/buildbot/pubsub.go
@@ -313,15 +313,15 @@ func pubSubHandlerImpl(c context.Context, r *http.Request) int {
return http.StatusInternalServerError
}
switch msg.Subscription {
- case settings.Buildbot.PublicTopic:
+ case settings.Buildbot.PublicSubscription:
internal = false
- case settings.Buildbot.InternalTopic:
+ case settings.Buildbot.InternalSubscription:
// internal = true, but that's already set.
default:
logging.Errorf(
c, "Subscription name %s does not match %s or %s",
- msg.Subscription, settings.Buildbot.PublicTopic,
- settings.Buildbot.InternalTopic)
+ msg.Subscription, settings.Buildbot.PublicSubscription,
+ settings.Buildbot.InternalSubscription)
// This is a configuration error. Tell PubSub to retry until we fix our
// configs.
return http.StatusInternalServerError
« no previous file with comments | « milo/appengine/buildbot/build_test.go ('k') | milo/common/config/settings.proto » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698