Check for SVN earlier in clang's update.py script

Check for SVN earlier in clang's update.py script

We need to do this before the calls to GetSvnRevision, because they run
svn.

BUG=706552
R=thakis@chromium.org,krasin@chromium.org

Review-Url: https://codereview.chromium.org/2784053003
Cr-Commit-Position: refs/heads/master@{#460631}
Committed: https://chromium.googlesource.com/chromium/src/+/f4cddb4364a978f6ba20cf0b5b4e48c924b121a8

[Nico, 2017-03-29 21:45:14]

lgtm

[Nico, 2017-03-29 21:53:07]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-29 21:53:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-03-29 22:02:37]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2017-03-29 22:03:40]

Wait, this is no good, as is all bots (and devs)  just running this to download
clang will now download svn as well. Can we make it so this only runs when we do
a local build?

[Reid Kleckner, 2017-03-29 22:10:33]

On 2017/03/29 22:03:40, Nico wrote:
> Wait, this is no good, as is all bots (and devs)  just running this to
download
> clang will now download svn as well. Can we make it so this only runs when we
do
> a local build?

Doh. I think the new patch set has the conditions right now.

[Reid Kleckner, 2017-03-29 22:10:58]

https://codereview.chromium.org/2784053003/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/2784053003/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:883: if (use_head_revision or
args.llvm_force_head_revision or
Do we need both the LLVM_USE_HEAD_REVISION environment variable and the
--llvm-force-head-revision flag?

[Nico, 2017-03-29 23:16:41]

Lgtm.

https://codereview.chromium.org/2784053003/diff/20001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/2784053003/diff/20001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:883: if (use_head_revision or
args.llvm_force_head_revision or
On 2017/03/29 22:10:57, Reid Kleckner wrote:
> Do we need both the LLVM_USE_HEAD_REVISION environment variable and the
> --llvm-force-head-revision flag?

Yes :-( This runs as a hook on bots, and there's no good way to conditionally
pass flags from DEPS. So we need the env var. And requiring people to set env
vars is criminal, so we need the flag. But the implementation should probably be
"if env var set, set flag" and the only look at the flag everywhere else. (Maybe
argparse even has some env reading thing).

[Reid Kleckner, 2017-03-30 00:11:55]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2017-03-30 00:12:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:14:56]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't
started yet, builder probably lacks capacity)

[Nico, 2017-03-30 02:24:24]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-03-30 02:24:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 02:54:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490840664727130,
"parent_rev": "600d3038e72aa2a0b9bb94a4bd9230226bd662a6", "commit_rev":
"f4cddb4364a978f6ba20cf0b5b4e48c924b121a8"}

[commit-bot: I haz the power, 2017-03-30 02:55:01]

Description was changed from

==========
Check for SVN earlier in clang's update.py script

We need to do this before the calls to GetSvnRevision, because they run
svn.

BUG=706552
R=thakis@chromium.org,krasin@chromium.org
==========

to

==========
Check for SVN earlier in clang's update.py script

We need to do this before the calls to GetSvnRevision, because they run
svn.

BUG=706552
R=thakis@chromium.org,krasin@chromium.org

Review-Url: https://codereview.chromium.org/2784053003
Cr-Commit-Position: refs/heads/master@{#460631}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4cddb4364a978f6ba20cf0b5b4e...
==========

[commit-bot: I haz the power, 2017-03-30 02:55:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f4cddb4364a978f6ba20cf0b5b4e...