Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: tools/clang/scripts/update.py

Issue 2784053003: Check for SVN earlier in clang's update.py script (Closed)
Patch Set: add a comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/scripts/update.py
diff --git a/tools/clang/scripts/update.py b/tools/clang/scripts/update.py
index 3953d672946bb17cc522ae7d2f8eb63d52627682..2ea0d6d3d21b8651672061f4e6df6abc2cd3ae42 100755
--- a/tools/clang/scripts/update.py
+++ b/tools/clang/scripts/update.py
@@ -450,7 +450,6 @@ def UpdateClang(args):
return 1
DownloadHostGcc(args)
- AddSvnToPathOnWin()
AddCMakeToPath()
AddGnuWinToPath()
@@ -881,6 +880,11 @@ def main():
print 'Skipping Clang update (make_clang_dir= was set in GYP_DEFINES).'
return 0
+ # Get svn if we're going to use it to check the revision or do a local build.
+ if (use_head_revision or args.llvm_force_head_revision or
+ args.force_local_build):
+ AddSvnToPathOnWin()
+
global CLANG_REVISION, PACKAGE_VERSION
if args.print_revision:
if use_head_revision or args.llvm_force_head_revision:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698