Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2783833002: Revert of [Merge] Fix minidump-related JobScheduler test failures. (Closed)

Created:
3 years, 8 months ago by Ilya Sherman
Modified:
3 years, 8 months ago
Reviewers:
gone
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Revert of [Merge] Fix minidump-related JobScheduler test failures. (patchset #1 id:1 of https://codereview.chromium.org/2779693004/ ) Reason for revert: Caused a build failure: crbug.com/706254. The tests need to be updated to use the old way of testing a Feature. Original issue's description: > [Merge] Fix minidump-related JobScheduler test failures. > > BUG=694884 > TEST=none > R=dfalcantara@chromium.org > > Review-Url: https://codereview.chromium.org/2753173002 > Cr-Commit-Position: refs/heads/master@{#457650} > (cherry picked from commit 0c77af249cab19e99fc0024b828373b1751633e2) > > Review-Url: https://codereview.chromium.org/2779693004 . > Cr-Commit-Position: refs/branch-heads/3029@{#460} > Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} > Committed: https://chromium.googlesource.com/chromium/src/+/2159626e1e7064876a3f9dc1c420b721f9aac1c2 TBR=dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=694884 Review-Url: https://codereview.chromium.org/2783833002 Cr-Commit-Position: refs/branch-heads/3029@{#467} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/453e42120a1d38e71c3f2b315b83899f8b310aef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ilya Sherman
Created Revert of [Merge] Fix minidump-related JobScheduler test failures.
3 years, 8 months ago (2017-03-29 04:00:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783833002/1
3 years, 8 months ago (2017-03-29 04:00:45 UTC) #3
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
3 years, 8 months ago (2017-03-29 04:03:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2783833002/1
3 years, 8 months ago (2017-03-29 04:04:38 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:06:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/453e42120a1d38e71c3f2b315b83...

Powered by Google App Engine
This is Rietveld 408576698